Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2168483004: Remove friendship from CXFA_Document to CXFA_SimpleParser. (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa_parser_V
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove friendship from CXFA_Document to CXFA_SimpleParser. This no longer seems to be needed (removing causes no issues). Committed: https://pdfium.googlesource.com/pdfium/+/987796a6f69c7970bcc8fa50202e88dc158cc39b

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M xfa/fxfa/parser/cxfa_document.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 5 months ago (2016-07-20 20:25:25 UTC) #2
Wei Li
lgtm
4 years, 5 months ago (2016-07-20 22:55:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2168483004/20001
4 years, 5 months ago (2016-07-21 19:10:09 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:11:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/987796a6f69c7970bcc8fa50202e88dc158c...

Powered by Google App Engine
This is Rietveld 408576698