Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2162263003: Remove CXFA_DocumentParser friendship with CXFA_SimpleParser (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa_parser_VI
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CXFA_DocumentParser friendship with CXFA_SimpleParser This CL moves the |SetFactory| method to be public and removes the friendship with CXFA_DocumentParser from CXFA_SimpleParser. Committed: https://pdfium.googlesource.com/pdfium/+/1235f6ff37394e7df2eecce539762d45e8860a5c

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M xfa/fxfa/parser/cxfa_simple_parser.h View 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 5 months ago (2016-07-20 19:42:14 UTC) #2
Lei Zhang
lgtm All these broken friendships. (and roman numerals)
4 years, 5 months ago (2016-07-20 22:58:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162263003/20001
4 years, 5 months ago (2016-07-21 19:11:28 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:11:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/1235f6ff37394e7df2eecce539762d45e886...

Powered by Google App Engine
This is Rietveld 408576698