Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2165833005: Rename xfa_utils_imp to xfa_utils (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa_parser_IV
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename xfa_utils_imp to xfa_utils This makes the cpp and unittest files match the naming of the header file. Committed: https://pdfium.googlesource.com/pdfium/+/39fdfc35fa32d7dc2e4aa8d2f0cb0a153037ce8d

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -510 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pdfium.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fxfa/parser/xfa_utils.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D xfa/fxfa/parser/xfa_utils_imp.cpp View 1 1 chunk +0 lines, -486 lines 0 comments Download
D xfa/fxfa/parser/xfa_utils_imp_unittest.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
A + xfa/fxfa/parser/xfa_utils_unittest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 5 months ago (2016-07-20 18:49:35 UTC) #2
Wei Li
lgtm
4 years, 5 months ago (2016-07-20 22:41:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165833005/20001
4 years, 5 months ago (2016-07-21 19:05:09 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:09:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/39fdfc35fa32d7dc2e4aa8d2f0cb0a153037...

Powered by Google App Engine
This is Rietveld 408576698