[DevTools] Explicitly require ResourceTreeModel

[DevTools] Explicitly require ResourceTreeModel

BUG=624494
Committed: https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24
Cr-Commit-Position: refs/heads/master@{#412894}

[eostroukhov-old, 2016-07-22 00:32:02]

The CQ bit was checked by eostroukhov@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 00:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov-old, 2016-07-22 00:33:11]

eostroukhov@google.com changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[eostroukhov-old, 2016-07-22 00:33:11]

Another part of that bigger CL.

[commit-bot: I haz the power, 2016-07-22 01:56:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 01:56:52]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-07-22 17:19:44]

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:401: var
resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(request.target());
If the request is from SW, there might be no resource tree model.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
(right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js:776:
resourceTreeModel.suspendReload();
Let's proxy suspendReload and resumeReload through TargetManager (as we do with
TargetManager.reloadPage).

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js
(right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js:43: if
(resourceTreeModel) {
This model doesn't work without frames at all.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:42:
this._resourceTreeModel = resourceTreeModel;
TODO(lushnikov): CSSModel should not depend on frames and ResourceTreeModel.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:248:
resourceTreeModel: function()
Let's not expose it.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:38:
WebInspector.NetworkLog = function(target, resourceTreeModel, networkManager)
Let's try to remove NetworkLog entirely. Or move it's functionality into
ResourceTreeModel. It's about page loads only.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:566:
this._path = this._path.trimURL(resourceTreeModel.inspectedPageDomain());
I don't like dependency from network to resource tree model. Should we introduce
Target.targetUrl() instead?

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:229: if
(target.hasDOMCapability())
Looks strange. How DOM capability is related to service workers?

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js:145:
this._reset();
TODO(dgozman): we don't have to reset on navigation.

[pfeldman, 2016-07-22 17:33:47]

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
(right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js:719: var
resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._target);
1) WebInspector.NetworkPanel.FilmStripRecorder should only exist for targets
with resource tree. You should pass it in the constructor along with the target.
This is worth a separate CL.

2) We should untangle UI capability that reloads the page from resource tree
model and block it on that level.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js
(right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js:42:
var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);
There should be no AppCacheModel when there is no resource tree model.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:248:
resourceTreeModel: function()
We should not expose one model from another.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:741: var frameId =
node.frameId() || this._resourceTreeModel.mainFrame.id;
We should instead send frameId along with the root node.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js
(right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js:80: var
frame = this._cssModel.resourceTreeModel().frameForId(this.frameId);
We should use url from the document instead
(WebInspector.DOMDocument.documentURL).

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js:143: if ((/**
@type {?WebInspector.Target} */ (event.target)) !== this.target())
This never happens.

[eostroukhov-old, 2016-07-25 19:30:20]

Comments were addressed

[eostroukhov-old, 2016-07-25 19:30:23]

The CQ bit was checked by eostroukhov@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 19:30:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov-old, 2016-07-25 19:36:11]

Thank you for the review. I uploaded a new CL version, please take another look.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:401: var
resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(request.target());
On 2016/07/22 17:19:43, dgozman wrote:
> If the request is from SW, there might be no resource tree model.

Done.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
(right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js:719: var
resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._target);
On 2016/07/22 17:33:47, pfeldman wrote:
> 1) WebInspector.NetworkPanel.FilmStripRecorder should only exist for targets
> with resource tree. You should pass it in the constructor along with the
target.
> This is worth a separate CL.
> 
> 2) We should untangle UI capability that reloads the page from resource tree
> model and block it on that level.

1) Ack, but not addressing here.
2) Routed through the target manager, as per dgozman suggestion below.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js:776:
resourceTreeModel.suspendReload();
On 2016/07/22 17:19:43, dgozman wrote:
> Let's proxy suspendReload and resumeReload through TargetManager (as we do
with
> TargetManager.reloadPage).

Done - both for the supend and resume.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js
(right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js:42:
var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(target);
On 2016/07/22 17:33:47, pfeldman wrote:
> There should be no AppCacheModel when there is no resource tree model.

Done.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ApplicationCacheModel.js:43: if
(resourceTreeModel) {
On 2016/07/22 17:19:43, dgozman wrote:
> This model doesn't work without frames at all.

Done.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:42:
this._resourceTreeModel = resourceTreeModel;
On 2016/07/22 17:19:43, dgozman wrote:
> TODO(lushnikov): CSSModel should not depend on frames and ResourceTreeModel.

Done.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:248:
resourceTreeModel: function()
On 2016/07/22 17:19:43, dgozman wrote:
> Let's not expose it.

Done.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:248:
resourceTreeModel: function()
On 2016/07/22 17:33:47, pfeldman wrote:
> We should not expose one model from another.

Done.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:741: var frameId =
node.frameId() || this._resourceTreeModel.mainFrame.id;
On 2016/07/22 17:33:47, pfeldman wrote:
> We should instead send frameId along with the root node.

Done.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js
(right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js:80: var
frame = this._cssModel.resourceTreeModel().frameForId(this.frameId);
On 2016/07/22 17:33:47, pfeldman wrote:
> We should use url from the document instead
> (WebInspector.DOMDocument.documentURL).

Done.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:38:
WebInspector.NetworkLog = function(target, resourceTreeModel, networkManager)
On 2016/07/22 17:19:43, dgozman wrote:
> Let's try to remove NetworkLog entirely. Or move it's functionality into
> ResourceTreeModel. It's about page loads only.

I would like not to do this in this CL - it is already growing too fast...

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js:566:
this._path = this._path.trimURL(resourceTreeModel.inspectedPageDomain());
On 2016/07/22 17:19:44, dgozman wrote:
> I don't like dependency from network to resource tree model. Should we
introduce
> Target.targetUrl() instead?

I don't know :) I think this might overlap wit Joel's work.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:229: if
(target.hasDOMCapability())
On 2016/07/22 17:19:44, dgozman wrote:
> Looks strange. How DOM capability is related to service workers?

Done.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js (right):

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js:143: if ((/**
@type {?WebInspector.Target} */ (event.target)) !== this.target())
On 2016/07/22 17:33:47, pfeldman wrote:
> This never happens.

Done.

https://codereview.chromium.org/2168323002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js:145:
this._reset();
On 2016/07/22 17:19:44, dgozman wrote:
> TODO(dgozman): we don't have to reset on navigation.

Added a comment, as per offline discussion.

[commit-bot: I haz the power, 2016-07-25 21:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 21:44:32]

Dry run: This issue passed the CQ dry run.

[eostroukhov-old, 2016-07-26 22:43:23]

URL management was split into a separate CL

[eostroukhov-old, 2016-07-26 22:45:59]

Please take another look. I know that ultimate goal is to detach
NetworkLog{,View} from the resourceTreeModel - but for now I suggest we just
keep the dependency, NetworkLog seem to be DOM-specific anyways.

[pfeldman, 2016-07-27 17:54:35]

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js
(right):

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js:42:
return this._resourceTreeModel || null;
This does not sound right, css should not need resource tree nor should it
expose it.

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js
(right):

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js:43:
return this._computedStyleModel.resourceTreeModel();
ditto

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:385:
var frameId = node.frameId() || this.resourceTreeModel().mainFrame.id;
We should be able to operate nodes only here.

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js (right):

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:752:
this._agent.createStyleSheet(frameId, innerCallback.bind(this))
We should be able to send document node id here.

[eostroukhov-old, 2016-08-05 18:28:04]

Comments addressed

[eostroukhov-old, 2016-08-05 18:32:03]

I addressed the comments, please take another look.

I would like to remind that per our offline discussion, for the time being
CSSModel will keep using ResourceTreeModel and it will expect it to exist at all
times. Getting rid of those dependencies requires protocol changes.

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js
(right):

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js:42:
return this._resourceTreeModel || null;
On 2016/07/27 17:54:35, pfeldman wrote:
> This does not sound right, css should not need resource tree nor should it
> expose it.

This method was left here by mistake, removed now.

Q: below, should I check for RTM separately from the rest?

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js
(right):

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js:43:
return this._computedStyleModel.resourceTreeModel();
On 2016/07/27 17:54:35, pfeldman wrote:
> ditto

Removed.

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:385:
var frameId = node.frameId() || this.resourceTreeModel().mainFrame.id;
On 2016/07/27 17:54:35, pfeldman wrote:
> We should be able to operate nodes only here.

Reverted the change.

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js (right):

https://codereview.chromium.org/2168323002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js:752:
this._agent.createStyleSheet(frameId, innerCallback.bind(this))
On 2016/07/27 17:54:35, pfeldman wrote:
> We should be able to send document node id here.

We discussed this offline and no change will be made here for now.

[eostroukhov-old, 2016-08-10 20:56:37]

Gentle ping

[pfeldman, 2016-08-11 00:34:17]

https://codereview.chromium.org/2168323002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
(left):

https://codereview.chromium.org/2168323002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js:700:
setImmediate(resourceTreeModel.resumeReload.bind(resourceTreeModel));
This setImmediate is lost.

https://codereview.chromium.org/2168323002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js
(right):

https://codereview.chromium.org/2168323002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js:80: var
doc = this._cssModel.domModel().existingDocument();
Depending on the iframe, these will be different documents.

[eostroukhov-old, 2016-08-17 01:09:03]

Please take another look.

https://codereview.chromium.org/2168323002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
(left):

https://codereview.chromium.org/2168323002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js:700:
setImmediate(resourceTreeModel.resumeReload.bind(resourceTreeModel));
On 2016/08/11 00:34:17, pfeldman wrote:
> This setImmediate is lost.

It moved to the TargetManager.js

https://codereview.chromium.org/2168323002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js
(right):

https://codereview.chromium.org/2168323002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js:80: var
doc = this._cssModel.domModel().existingDocument();
On 2016/08/11 00:34:17, pfeldman wrote:
> Depending on the iframe, these will be different documents.

Rewrote, assuming RTModel is always there.

[dgozman, 2016-08-17 01:37:52]

https://codereview.chromium.org/2168323002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2168323002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:194:
target.resourceTreeModel = new WebInspector.ResourceTreeModel(target,
networkManager, securityOriginManager);
Don't assign it here, so that compilation catches more cases.
Can we stop creating it for non-dom targets?

[eostroukhov, 2016-08-17 23:19:37]

eostroukhov@chromium.org changed reviewers:
+ eostroukhov@chromium.org

[eostroukhov, 2016-08-17 23:19:38]

(No change to the code)

https://codereview.chromium.org/2168323002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js (right):

https://codereview.chromium.org/2168323002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js:194:
target.resourceTreeModel = new WebInspector.ResourceTreeModel(target,
networkManager, securityOriginManager);
On 2016/08/17 01:37:52, dgozman wrote:
> Don't assign it here, so that compilation catches more cases.
> Can we stop creating it for non-dom targets?

I split the CL to make review easier. Next CLs will fix references in other
folders - then we will be able not to create the model.

[dgozman, 2016-08-18 01:02:13]

lgtm

[dgozman, 2016-08-18 01:02:29]

On 2016/08/18 01:02:13, dgozman wrote:
> lgtm

Please make description more descriptive though.

[eostroukhov, 2016-08-18 17:04:11]

The CQ bit was checked by eostroukhov@chromium.org

[commit-bot: I haz the power, 2016-08-18 17:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 18:26:03]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-18 18:27:38]

Description was changed from

==========
[DevTools] Explicitly require ResourceTreeModel

BUG=624494
==========

to

==========
[DevTools] Explicitly require ResourceTreeModel

BUG=624494

Committed: https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24
Cr-Commit-Position: refs/heads/master@{#412894}
==========

[commit-bot: I haz the power, 2016-08-18 18:27:39]

Patchset 5 (id:??) landed as
https://crrev.com/9dd9c79c7dbb77d370e6f17ee504320a76aaac24
Cr-Commit-Position: refs/heads/master@{#412894}