third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js - Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [DevTools] Explicitly require ResourceTreeModel Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

index 3ea499a9be83612b575d653cd97aeafcbe373a52..4da69bc2111de205485f00cafb09b05074a71a8a 100644

--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

@@ -248,10 +248,11 @@ WebInspector.SecurityPanel.prototype = {

this._target = target;

- if (target.hasBrowserCapability()) {

- target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this);

- target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.InterstitialShown, this._onInterstitialShown, this);

- target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.InterstitialHidden, this._onInterstitialHidden, this);

+ var resourceTreeModel = WebInspector.ResourceTreeModel.fromTarget(this._target);

+ if (resourceTreeModel) {

+ resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._onMainFrameNavigated, this);

+ resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.InterstitialShown, this._onInterstitialShown, this);

+ resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.InterstitialHidden, this._onInterstitialHidden, this);

}

var networkManager = WebInspector.NetworkManager.fromTarget(target);