third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js - Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2168323002: [DevTools] Explicitly require ResourceTreeModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [DevTools] Explicitly require ResourceTreeModel Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

index f855da8c3362c3a24022775423f275ae0708ee16..1c78a7899415ad3644a220dce5589e2c4ae73ad3 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

@@ -695,9 +695,8 @@ WebInspector.NetworkPanel.FilmStripRecorder.prototype = {

if (!this._tracingModel)

return;

this._tracingModel.tracingComplete();

- var resourceTreeModel = this._target.resourceTreeModel;

+ WebInspector.targetManager.resumeReload(this._target);

this._target = null;

- setImmediate(resourceTreeModel.resumeReload.bind(resourceTreeModel));

this._callback(new WebInspector.FilmStripModel(this._tracingModel, this._timeCalculator.minimumBoundary() * 1000));

delete this._callback;

@@ -749,7 +748,7 @@ WebInspector.NetworkPanel.FilmStripRecorder.prototype = {

return;

this._target.tracingManager.stop();

- this._target.resourceTreeModel.suspendReload();

+ WebInspector.targetManager.suspendReload(this._target);

this._callback = callback;

this._filmStripView.setStatusText(WebInspector.UIString("Fetching frames..."));

}