Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2167883004: [Skia] Convert SKPs to a CIPD package (Closed)

Created:
4 years, 5 months ago by borenet2
Modified:
4 years, 5 months ago
Reviewers:
borenet, rmistry, rmistry1
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Skia] Convert SKPs to a CIPD package This CL changes the RecreateSKPs bot to create the CIPD package and tells normal bots to use it if available. BUG=skia:5427 Committed: https://chromium.googlesource.com/chromium/tools/build/+/133cb0b27cf5f8f71a4a335fc99b8a111d4332b0

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : Fixes #

Patch Set 4 : Fix boto env, ensure tmp_dir exists since it's no longer isolated #

Total comments: 6

Patch Set 5 : Address comments #

Patch Set 6 : Non-canary bot provides --upload_to_partner_bucket #

Unified diffs Side-by-side diffs Delta from patch set Stats (+705 lines, -623 lines) Patch
M scripts/slave/recipe_modules/skia/api.py View 1 2 3 3 chunks +28 lines, -10 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_RecreateSKPs.py View 1 2 3 4 5 3 chunks +44 lines, -19 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json View 1 2 3 3 chunks +55 lines, -45 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json View 1 2 3 4 5 3 chunks +88 lines, -6 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_housekeeper.expected/Housekeeper-PerCommit.json View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_housekeeper.expected/Housekeeper-PerCommit-Trybot.json View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.py View 2 chunks +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/big_issue_number.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.py View 10 chunks +36 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug.json View 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 4 chunks +15 lines, -5 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/adb_in_path.json View 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/big_issue_number.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/download_and_push_skimage.json View 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/download_and_push_skps.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/failed_dm.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/failed_get_hashes.json View 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/legacy_skimage_version.json View 2 chunks +13 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/skia/swarm_test.expected/legacy_skp_version.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/missing_SKP_VERSION_device.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json View 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.py View 1 2 3 4 6 chunks +21 lines, -5 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json View 2 chunks +4 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug-Vulkan.json View 3 chunks +6 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-Nexus7v2-GPU-Tegra3-Arm7-Release.json View 2 chunks +4 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release.json View 2 chunks +4 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 2 chunks +4 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 3 chunks +6 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 3 chunks +6 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 3 chunks +6 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleA-GPU-HD7770-x86_64-Release.json View 2 chunks +4 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release.json View 2 chunks +4 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release.json View 2 chunks +4 lines, -34 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json View 4 chunks +14 lines, -20 lines 0 comments Download
A + scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skp_version.json View 5 chunks +5 lines, -5 lines 0 comments Download
D scripts/slave/skia/recreate_skps.py View 1 chunk +0 lines, -58 lines 0 comments Download
A + scripts/slave/skia/upload_skps.py View 1 2 2 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
borenet
Still waiting on tests to come back for final confirmation, but generally ready for review.
4 years, 5 months ago (2016-07-21 18:37:33 UTC) #3
rmistry
lgtm https://codereview.chromium.org/2167883004/diff/60001/scripts/slave/recipes/skia/swarm_RecreateSKPs.py File scripts/slave/recipes/skia/swarm_RecreateSKPs.py (right): https://codereview.chromium.org/2167883004/diff/60001/scripts/slave/recipes/skia/swarm_RecreateSKPs.py#newcode16 scripts/slave/recipes/skia/swarm_RecreateSKPs.py:16: 'file', nit: sort https://codereview.chromium.org/2167883004/diff/60001/scripts/slave/recipes/skia/swarm_trigger.py File scripts/slave/recipes/skia/swarm_trigger.py (right): https://codereview.chromium.org/2167883004/diff/60001/scripts/slave/recipes/skia/swarm_trigger.py#newcode677 ...
4 years, 5 months ago (2016-07-22 14:26:15 UTC) #5
borenet
https://codereview.chromium.org/2167883004/diff/60001/scripts/slave/recipes/skia/swarm_RecreateSKPs.py File scripts/slave/recipes/skia/swarm_RecreateSKPs.py (right): https://codereview.chromium.org/2167883004/diff/60001/scripts/slave/recipes/skia/swarm_RecreateSKPs.py#newcode16 scripts/slave/recipes/skia/swarm_RecreateSKPs.py:16: 'file', On 2016/07/22 14:26:14, rmistry wrote: > nit: sort ...
4 years, 5 months ago (2016-07-22 14:49:54 UTC) #6
rmistry
On 2016/07/22 14:49:54, borenet wrote: > https://codereview.chromium.org/2167883004/diff/60001/scripts/slave/recipes/skia/swarm_RecreateSKPs.py > File scripts/slave/recipes/skia/swarm_RecreateSKPs.py (right): > > https://codereview.chromium.org/2167883004/diff/60001/scripts/slave/recipes/skia/swarm_RecreateSKPs.py#newcode16 > ...
4 years, 5 months ago (2016-07-22 14:51:51 UTC) #7
borenet
On 2016/07/22 14:51:51, rmistry wrote: > On 2016/07/22 14:49:54, borenet wrote: > > > https://codereview.chromium.org/2167883004/diff/60001/scripts/slave/recipes/skia/swarm_RecreateSKPs.py ...
4 years, 5 months ago (2016-07-22 15:00:23 UTC) #8
rmistry
lgtm
4 years, 5 months ago (2016-07-22 15:01:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167883004/100001
4 years, 5 months ago (2016-07-22 15:02:18 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 15:06:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/tools/build/+/133cb0b27cf5f8f71a4a...

Powered by Google App Engine
This is Rietveld 408576698