scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json - Issue 2167883004: [Skia] Convert SKPs to a CIPD package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json

Issue 2167883004: [Skia] Convert SKPs to a CIPD package (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Non-canary bot provides --upload_to_partner_bucket Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/skia/swarm_trigger.py ('k') | scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug-Vulkan.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json

diff --git a/scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json b/scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json

index 50173f8c6e372bce651363934cfdc54f4d8176c6..b8f4ca8ff2b97c2a7d04e31fb831c45201aa9c44 100644

--- a/scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json

+++ b/scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json

@@ -710,43 +710,11 @@

"cmd": [

"python",

"-u",

- "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os.path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n",

- "[SLAVE_BUILD]/tmp",

- "511"

- ],

- "name": "makedirs tmp_dir",

- "~followup_annotations": [

- "@@@STEP_LOG_LINE@python.inline@@@@",

- "@@@STEP_LOG_LINE@python.inline@import sys, os@@@",

- "@@@STEP_LOG_LINE@python.inline@path = sys.argv[1]@@@",

- "@@@STEP_LOG_LINE@python.inline@mode = int(sys.argv[2])@@@",

- "@@@STEP_LOG_LINE@python.inline@if not os.path.isdir(path):@@@",

- "@@@STEP_LOG_LINE@python.inline@ if os.path.exists(path):@@@",

- "@@@STEP_LOG_LINE@python.inline@ print \"%s exists but is not a dir\" % path@@@",

- "@@@STEP_LOG_LINE@python.inline@ sys.exit(1)@@@",

- "@@@STEP_LOG_LINE@python.inline@ os.makedirs(path, mode)@@@",

- "@@@STEP_LOG_END@python.inline@@@"

- ]

- },

- {

- "cmd": [

- "python",

- "-u",

- "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

- "[SLAVE_BUILD]/tmp/SKP_VERSION",

- "/path/to/tmp/"

- ],

- "name": "Get downloaded SKP_VERSION"

- },

- {

- "cmd": [

- "python",

- "-u",

"\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

- "[SLAVE_BUILD]/skia/SKP_VERSION",

+ "[SLAVE_BUILD]/skia/infra/bots/assets/skp/VERSION",

"/path/to/tmp/"

- "name": "Get expected SKP_VERSION"

+ "name": "read skp VERSION"

{

"cmd": [

@@ -908,6 +876,8 @@

"--tag",

"stepname:perf_skia on Ubuntu",

"--cipd-package",

+ "skp:skia/bots/skp:version:0",

+ "--cipd-package",

"skimage:skia/bots/skimage:version:0",

"def456",

"--",