[Skia] Convert SKPs to a CIPD package

scripts/slave/skia/upload_skps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Create a CL to update the SKP version."""
 
 
 import argparse
 import os
 import subprocess
@@ skipping 11 matching lines @@
 Automatic commit by the RecreateSKPs bot.
 
 TBR=
 NO_MERGE_BUILDS
 '''
 SKIA_COMMITTER_EMAIL = 'skia.buildbots@gmail.com'
 SKIA_COMMITTER_NAME = 'skia.buildbots'
 SKIA_REPO = 'https://skia.googlesource.com/skia.git'
 
 
-def main(chrome_src_path, browser_executable, dry_run=False):
-  if dry_run:
-    print 'Not committing results since --dry-run was provided'
-
+def main(target_dir):
   subprocess.check_call(['git', 'config', '--local', 'user.name',
                          SKIA_COMMITTER_NAME])
   subprocess.check_call(['git', 'config', '--local', 'user.email',
                          SKIA_COMMITTER_EMAIL])
   if CHROMIUM_SKIA in subprocess.check_output(['git', 'remote', '-v']):
     subprocess.check_call(['git', 'remote', 'set-url', 'origin', SKIA_REPO,
                            CHROMIUM_SKIA])
 
+  # Download CIPD.
+  cipd_sha1 = os.path.join(os.getcwd(), 'infra', 'bots', 'tools', 'luci-go',
+                           'linux64', 'cipd.sha1')
+  subprocess.check_call(['download_from_google_storage', '-s', cipd_sha1,
+                         '--bucket', 'chromium-luci'])
+
   with git_utils.GitBranch(branch_name='update_skp_version',
                            commit_msg=COMMIT_MSG,
-                           commit_queue=not dry_run):
-    subprocess.check_call(['python', os.path.join('tools', 'skp',
-                                                  'recreate_skps.py'),
-                           chrome_src_path, browser_executable, str(dry_run)])
+                           commit_queue=True):
+    upload_script = os.path.join(
+        os.getcwd(), 'infra', 'bots', 'assets', 'skp', 'upload.py')
+    subprocess.check_call(['python', upload_script, '-t', target_dir])
+
+  # TODO(borenet): Upload to partner GS bucket?

[rmistry, 2016/07/22 14:26:15]

Is this not being done? I thought it would be done by webpages_playback.py ?

[borenet, 2016/07/22 14:49:53]

I removed the flag which caused that to occur in
https://codereview.chromium.org/2167763002/diff/60001/infra/bots/assets/skp/c...
.  Maybe it should be added back there?

 
 
 if '__main__' == __name__:
   parser = argparse.ArgumentParser()
-  parser.add_argument("chrome_src_path")
-  parser.add_argument("browser_executable")
-  parser.add_argument("--dry-run", action="store_true")
+  parser.add_argument("--target_dir")
   args = parser.parse_args()
-  main(args.chrome_src_path, args.browser_executable, args.dry_run)
+  main(args.target_dir)