Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 216773002: Relanding Switched main WebRTC browser tests to use a more realistic video (Closed)

Created:
6 years, 9 months ago by phoglund_chromium
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

Relanding Switched main WebRTC browser tests to use a more realistic video > Switched main WebRTC browser tests to use a more realistic video. > After switching to fake device flags instead of software webcams, we > noticed a ton of video-related metrics changed. This is because the > spinning green ball is an unrealistic encode/decode example. This patch > will use the new fake device file flag to play a more realistic video. > BUG=352261, 343504 > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259887 TBR=tommi@chromium.org BUG=352261, 343504 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -121 lines) Patch
M chrome/browser/media/chrome_media_stream_infobar_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_browsertest.cc View 12 chunks +42 lines, -12 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_typing_detection_browsertest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 8 chunks +13 lines, -61 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 7 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_common.h View 2 chunks +22 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc_browsertest_common.cc View 5 chunks +77 lines, -6 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_perf.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_perf.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/data/webrtc/webrtc_jsep01_test.html View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
phoglund_chromium
We can't run this particular test on our xp bots anymore since the xp bots ...
6 years, 9 months ago (2014-03-28 10:04:10 UTC) #1
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 9 months ago (2014-03-28 10:04:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/216773002/1
6 years, 9 months ago (2014-03-28 10:05:10 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 15:05:28 UTC) #4
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) components_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=137320
6 years, 8 months ago (2014-03-28 15:05:29 UTC) #5
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 8 months ago (2014-03-28 15:57:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/216773002/1
6 years, 8 months ago (2014-03-28 16:02:06 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 18:40:00 UTC) #8
Message was sent while issue was closed.
Change committed as 260213

Powered by Google App Engine
This is Rietveld 408576698