Relanding Switched main WebRTC browser tests to use a more realistic video

chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/environment.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/process/launch.h"
 #include "base/strings/string_split.h"
 #include "base/strings/stringprintf.h"
@@ skipping 43 matching lines @@
 static const char kHomeEnvName[] =
 #if defined(OS_WIN)
     "HOMEPATH";
 #else
     "HOME";
 #endif
 
 // The working dir should be in the user's home folder.
 static const base::FilePath::CharType kWorkingDirName[] =
     FILE_PATH_LITERAL("webrtc_video_quality");
-static const base::FilePath::CharType kReferenceVideosDirName[] =
-    FILE_PATH_LITERAL("webrtc.DEPS/webrtc_videos");
-static const base::FilePath::CharType kReferenceFileName360p[] =
-    FILE_PATH_LITERAL("reference_video_640x360_30fps");
-static const base::FilePath::CharType kYuvFileExtension[] =
-    FILE_PATH_LITERAL("yuv");
-static const base::FilePath::CharType kY4mFileExtension[] =
-    FILE_PATH_LITERAL("y4m");
 static const base::FilePath::CharType kCapturedYuvFileName[] =
     FILE_PATH_LITERAL("captured_video.yuv");
 static const base::FilePath::CharType kStatsFileName[] =
     FILE_PATH_LITERAL("stats.txt");
 static const char kMainWebrtcTestHtmlPage[] =
     "/webrtc/webrtc_jsep01_test.html";
 static const char kCapturingWebrtcHtmlPage[] =
     "/webrtc/webrtc_video_quality_test.html";
 static const int k360pWidth = 640;
 static const int k360pHeight = 360;
 
 // If you change the port number, don't forget to modify video_extraction.js
 // too!
 static const char kPyWebSocketPortNumber[] = "12221";
 
-const char kAdviseOnGclientSolution[] =
-    "You need to add this solution to your .gclient to run this test:\n"
-    "{\n"
-    "  \"name\"        : \"webrtc.DEPS\",\n"
-    "  \"url\"         : \"svn://svn.chromium.org/chrome/trunk/deps/"
-    "third_party/webrtc/webrtc.DEPS\",\n"
-    "}";
-
 // Test the video quality of the WebRTC output.
 //
 // Prerequisites: This test case must run on a machine with a chrome playing
 // the video from the reference files located int GetReferenceVideosDir().
 // The file kReferenceY4mFileName.kY4mFileExtension is played using a
 // FileVideoCaptureDevice and its sibling with kYuvFileExtension is used for
 // comparison.
 //
 // You must also compile the chromium_builder_webrtc target before you run this
 // test to get all the tools built.
@@ skipping 10 matching lines @@
 // frame_analyzer. Both tools can be found under third_party/webrtc/tools. The
 // test also runs a stand alone Python implementation of a WebSocket server
 // (pywebsocket) and a barcode_decoder script.
 class WebRtcVideoQualityBrowserTest : public WebRtcTestBase {
  public:
   WebRtcVideoQualityBrowserTest()
       : pywebsocket_server_(0),
         environment_(base::Environment::Create()) {}
 
   virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
-    PeerConnectionServerRunner::KillAllPeerConnectionServersOnCurrentSystem();
+    test::PeerConnectionServerRunner::KillAllPeerConnectionServers();
     DetectErrorsInJavaScript();  // Look for errors in our rather complex js.
   }
 
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
     // Set up the command line option with the expected file name. We will check
     // its existence in HasAllRequiredResources().
-    webrtc_reference_video_y4m_ = GetReferenceVideosDir()
-        .Append(kReferenceFileName360p).AddExtension(kY4mFileExtension);
+    webrtc_reference_video_y4m_ = test::GetReferenceVideosDir()
+        .Append(test::kReferenceFileName360p)
+        .AddExtension(test::kY4mFileExtension);
     command_line->AppendSwitchPath(switches::kUseFileForFakeVideoCapture,
                                    webrtc_reference_video_y4m_);
     command_line->AppendSwitch(switches::kUseFakeDeviceForMediaStream);
 
     // The video playback will not work without a GPU, so force its use here.
     command_line->AppendSwitch(switches::kUseGpuInTests);
   }
 
   bool HasAllRequiredResources() {
     if (!base::PathExists(GetWorkingDir())) {
       LOG(ERROR) << "Cannot find the working directory for the temporary "
           "files:" << GetWorkingDir().value();
       return false;
     }
-    if (!base::PathExists(GetReferenceVideosDir())) {
-      LOG(ERROR) << "Cannot find the working directory for the reference video "
-          "files, expected at " << GetReferenceVideosDir().value() << ". " <<
-          kAdviseOnGclientSolution;
-      return false;
-    }
-    base::FilePath webrtc_reference_video_yuv = GetReferenceVideosDir()
-        .Append(kReferenceFileName360p).AddExtension(kYuvFileExtension);
-    if (!base::PathExists(webrtc_reference_video_yuv)) {
-      LOG(ERROR) << "Missing YUV reference video to be used for quality"
-          << " comparison, expected at " << webrtc_reference_video_yuv.value()
-          << ". " << kAdviseOnGclientSolution;
-      return false;
-    }
-    if (!base::PathExists(webrtc_reference_video_y4m_)) {
-      LOG(ERROR) << "Missing Y4M reference video to be used for quality"
-          << " comparison, expected at "<< webrtc_reference_video_y4m_.value()
-          << ". " << kAdviseOnGclientSolution;
-      return false;
-    }
-    return true;
+
+    // Ensure we have the required input files.
+    return test::HasReferenceFilesInCheckout();
   }
 
   bool StartPyWebSocketServer() {
     base::FilePath path_pywebsocket_dir =
         GetSourceDir().Append(FILE_PATH_LITERAL("third_party/pywebsocket/src"));
     base::FilePath pywebsocket_server = path_pywebsocket_dir.Append(
         FILE_PATH_LITERAL("mod_pywebsocket/standalone.py"));
     base::FilePath path_to_data_handler =
         GetSourceDir().Append(FILE_PATH_LITERAL("chrome/test/functional"));
 
@@ skipping 125 matching lines @@
   }
 
   base::FilePath GetWorkingDir() {
     std::string home_dir;
     environment_->GetVar(kHomeEnvName, &home_dir);
     base::FilePath::StringType native_home_dir(home_dir.begin(),
                                                home_dir.end());
     return base::FilePath(native_home_dir).Append(kWorkingDirName);
   }
 
-  base::FilePath GetReferenceVideosDir() {
-    // FilePath does not tolerate relative paths, and we want to hang the
-    // kReferenceVideosDirName at the same level as Chromium codebase, so we
-    // need to subtract the trailing .../src manually from the path.
-    const size_t src_token_length = 3u;
-    const base::FilePath::StringType src_token(FILE_PATH_LITERAL("src"));
-    base::FilePath::StringType path = GetSourceDir().value();
-    DCHECK_GT(path.size(), src_token_length);
-    std::size_t found = path.rfind(src_token);
-    if (found != std::string::npos)
-      path.replace(found,
-                   src_token_length,
-                   base::FilePath::StringType(FILE_PATH_LITERAL("")));
-    return base::FilePath(path).Append(kReferenceVideosDirName);
-  }
-
-  PeerConnectionServerRunner peerconnection_server_;
+  test::PeerConnectionServerRunner peerconnection_server_;
 
  private:
   base::FilePath GetSourceDir() {
     base::FilePath source_dir;
     PathService::Get(base::DIR_SOURCE_ROOT, &source_dir);
     return source_dir;
   }
 
   base::FilePath GetBrowserDir() {
     base::FilePath browser_dir;
@@ skipping 31 matching lines @@
       OpenPageAndGetUserMediaInNewTabWithConstraints(
           embedded_test_server()->GetURL(kCapturingWebrtcHtmlPage),
           kAudioVideoCallConstraints360p);
 
   EstablishCall(left_tab, right_tab);
 
   // Poll slower here to avoid flooding the log with messages: capturing and
   // sending frames take quite a bit of time.
   int polling_interval_msec = 1000;
 
-  EXPECT_TRUE(PollingWaitUntil(
+  EXPECT_TRUE(test::PollingWaitUntil(
       "doneFrameCapturing()", "done-capturing", right_tab,
       polling_interval_msec));
 
   HangUp(left_tab);
   WaitUntilHangupVerified(left_tab);
   WaitUntilHangupVerified(right_tab);
 
-  EXPECT_TRUE(PollingWaitUntil(
+  EXPECT_TRUE(test::PollingWaitUntil(
       "haveMoreFramesToSend()", "no-more-frames", right_tab,
       polling_interval_msec));
 
   // Shut everything down to avoid having the javascript race with the analysis
   // tools. For instance, dont have console log printouts interleave with the
   // RESULT lines from the analysis tools (crbug.com/323200).
   ASSERT_TRUE(peerconnection_server_.Stop());
   ASSERT_TRUE(ShutdownPyWebSocketServer());
 
   chrome::CloseWebContents(browser(), left_tab, false);
   chrome::CloseWebContents(browser(), right_tab, false);
 
   RunARGBtoI420Converter(
       k360pWidth, k360pHeight, GetWorkingDir().Append(kCapturedYuvFileName));
   ASSERT_TRUE(CompareVideosAndPrintResult(
       k360pWidth,
       k360pHeight,
       GetWorkingDir().Append(kCapturedYuvFileName),
-      GetReferenceVideosDir().Append(kReferenceFileName360p).AddExtension(
-          kYuvFileExtension),
+      test::GetReferenceVideosDir()
+          .Append(test::kReferenceFileName360p)
+          .AddExtension(test::kYuvFileExtension),
       GetWorkingDir().Append(kStatsFileName)));
 }