Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1806)

Unified Diff: chrome/browser/media/webrtc_browsertest_common.h

Issue 216773002: Relanding Switched main WebRTC browser tests to use a more realistic video (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/webrtc_browsertest_base.cc ('k') | chrome/browser/media/webrtc_browsertest_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_browsertest_common.h
diff --git a/chrome/browser/media/webrtc_browsertest_common.h b/chrome/browser/media/webrtc_browsertest_common.h
index 9d51c172b50e47eff8eec0bb61f34d61f131e3a0..56d3eceb25ed1c6062b22c7a14e5e7e93c102d59 100644
--- a/chrome/browser/media/webrtc_browsertest_common.h
+++ b/chrome/browser/media/webrtc_browsertest_common.h
@@ -7,12 +7,31 @@
#include <string>
+#include "base/files/file_path.h"
#include "base/process/process_handle.h"
namespace content {
class WebContents;
}
+namespace test {
+
+// Reference video locations.
+
+// Checks if the user has the reference video files, returns true if so.
+// If the user's checkout don't have these dirs, they need to configure their
+// .gclient as described in kAdviseOnGclientSolution. The reason for this is
+// that we don't want to burden regular chrome devs with downloading these
+// sizable reference files by default.
+bool HasReferenceFilesInCheckout();
+
+// Retrieves the reference video dir, to which file names can be appended.
+base::FilePath GetReferenceVideosDir();
+
+extern const base::FilePath::CharType kReferenceFileName360p[];
+extern const base::FilePath::CharType kYuvFileExtension[];
+extern const base::FilePath::CharType kY4mFileExtension[];
+
// Executes javascript code which will sleep for |timeout_msec| milliseconds.
// Returns true on success.
bool SleepInJavascript(content::WebContents* tab_contents, int timeout_msec);
@@ -44,10 +63,12 @@ class PeerConnectionServerRunner {
// Stops the peerconnection server.
bool Stop();
- static void KillAllPeerConnectionServersOnCurrentSystem();
+ static void KillAllPeerConnectionServers();
private:
base::ProcessHandle server_pid_;
};
+} // namespace test
+
#endif // CHROME_BROWSER_MEDIA_WEBRTC_BROWSERTEST_COMMON_H_
« no previous file with comments | « chrome/browser/media/webrtc_browsertest_base.cc ('k') | chrome/browser/media/webrtc_browsertest_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698