Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2167593002: [turbofan] Introduce TruncateTaggedToBit operator for ToBoolean truncation. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce TruncateTaggedToBit operator for ToBoolean truncation. Add a dedicated simplified operator to inline the general case for the ToBoolean conversion. In a follow up CL we will also use the ToBoolean hints gathered by the baseline compiler. CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_arm64_gc_stress_dbg R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/8c50b51ab3d21efcd2f6900d83962159f21e1590 Committed: https://crrev.com/7954b3f8fa6a9fc6c884953d2615dea3018f52be Cr-Original-Commit-Position: refs/heads/master@{#37882} Cr-Commit-Position: refs/heads/master@{#39420}

Patch Set 1 #

Patch Set 2 : Fix DCHECK. #

Patch Set 3 : REBASE #

Patch Set 4 : Fix remaining bugs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -25 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 2 3 chunks +154 lines, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/representation-change.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 2 3 2 chunks +25 lines, -6 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 2 3 1 chunk +0 lines, -16 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (22 generated)
Benedikt Meurer
Hey Jaro, Here's a first step to ToBoolean optimization. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-20 06:17:56 UTC) #11
Jarin
lgtm
4 years, 5 months ago (2016-07-20 06:33:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167593002/20001
4 years, 5 months ago (2016-07-20 06:43:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 06:45:47 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8c50b51ab3d21efcd2f6900d83962159f21e1590 Cr-Commit-Position: refs/heads/master@{#37882}
4 years, 5 months ago (2016-07-20 06:49:30 UTC) #18
Michael Achenbach
This broke arm64 gc stress: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/1605 Fails reliably.
4 years, 5 months ago (2016-07-20 10:08:05 UTC) #19
Benedikt Meurer
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2170433002/ by bmeurer@chromium.org. ...
4 years, 5 months ago (2016-07-20 10:16:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167593002/60001
4 years, 3 months ago (2016-09-14 12:26:42 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-14 13:12:17 UTC) #30
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 13:12:36 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7954b3f8fa6a9fc6c884953d2615dea3018f52be
Cr-Commit-Position: refs/heads/master@{#39420}

Powered by Google App Engine
This is Rietveld 408576698