Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Side by Side Diff: src/compiler/verifier.cc

Issue 2167593002: [turbofan] Introduce TruncateTaggedToBit operator for ToBoolean truncation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix remaining bugs. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/simplified-operator.cc ('k') | test/cctest/compiler/test-representation-change.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 975 matching lines...) Expand 10 before | Expand all | Expand 10 after
986 } 986 }
987 case IrOpcode::kTruncateTaggedToWord32: { 987 case IrOpcode::kTruncateTaggedToWord32: {
988 // Number /\ Tagged -> Signed32 /\ UntaggedInt32 988 // Number /\ Tagged -> Signed32 /\ UntaggedInt32
989 // TODO(neis): Activate once ChangeRepresentation works in typer. 989 // TODO(neis): Activate once ChangeRepresentation works in typer.
990 // Type* from = Type::Intersect(Type::Number(), Type::Tagged()); 990 // Type* from = Type::Intersect(Type::Number(), Type::Tagged());
991 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedInt32()); 991 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedInt32());
992 // CheckValueInputIs(node, 0, from)); 992 // CheckValueInputIs(node, 0, from));
993 // CheckTypeIs(node, to)); 993 // CheckTypeIs(node, to));
994 break; 994 break;
995 } 995 }
996 case IrOpcode::kTruncateTaggedToBit:
997 break;
998
996 case IrOpcode::kCheckBounds: 999 case IrOpcode::kCheckBounds:
997 CheckValueInputIs(node, 0, Type::Any()); 1000 CheckValueInputIs(node, 0, Type::Any());
998 CheckValueInputIs(node, 1, Type::Unsigned31()); 1001 CheckValueInputIs(node, 1, Type::Unsigned31());
999 CheckTypeIs(node, Type::Unsigned31()); 1002 CheckTypeIs(node, Type::Unsigned31());
1000 break; 1003 break;
1001 case IrOpcode::kCheckMaps: 1004 case IrOpcode::kCheckMaps:
1002 // (Any, Internal, ..., Internal) -> Any 1005 // (Any, Internal, ..., Internal) -> Any
1003 CheckValueInputIs(node, 0, Type::Any()); 1006 CheckValueInputIs(node, 0, Type::Any());
1004 for (int i = 1; i < node->op()->ValueInputCount(); ++i) { 1007 for (int i = 1; i < node->op()->ValueInputCount(); ++i) {
1005 CheckValueInputIs(node, i, Type::Internal()); 1008 CheckValueInputIs(node, i, Type::Internal());
(...skipping 581 matching lines...) Expand 10 before | Expand all | Expand 10 after
1587 replacement->op()->EffectOutputCount() > 0); 1590 replacement->op()->EffectOutputCount() > 0);
1588 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1591 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1589 replacement->opcode() == IrOpcode::kFrameState); 1592 replacement->opcode() == IrOpcode::kFrameState);
1590 } 1593 }
1591 1594
1592 #endif // DEBUG 1595 #endif // DEBUG
1593 1596
1594 } // namespace compiler 1597 } // namespace compiler
1595 } // namespace internal 1598 } // namespace internal
1596 } // namespace v8 1599 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/simplified-operator.cc ('k') | test/cctest/compiler/test-representation-change.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698