Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2167223002: Revert of Creating framework for drawShadowedPicture (Closed)

Created:
4 years, 5 months ago by vjiaoblack
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Creating framework for drawShadowedPicture (patchset #14 id:260001 of https://codereview.chromium.org/2146073003/ ) Reason for revert: Decided to re-wait for a final LGTM. Already found a bug in variable naming to fix. Original issue's description: > Creating framework for drawShadowedPicture > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003 > > Committed: https://skia.googlesource.com/skia/+/0ae097d116f4332be02a135ffc99c162473dee6a TBR=reed@google.com,robertphillips@google.com,bsalomon@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/33d325890e549c113a258248002246b46e8040b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -409 lines) Patch
M gyp/common.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M gyp/common_variables.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkCanvas.h View 6 chunks +0 lines, -53 lines 0 comments Download
M include/core/SkLights.h View 6 chunks +1 line, -32 lines 0 comments Download
M include/private/SkRecords.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/core/SkCanvas.cpp View 4 chunks +0 lines, -31 lines 0 comments Download
M src/core/SkLightingShader.cpp View 3 chunks +1 line, -5 lines 0 comments Download
M src/core/SkPictureFlat.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/core/SkPictureRecord.h View 3 chunks +2 lines, -15 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 3 chunks +0 lines, -23 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 3 chunks +0 lines, -17 lines 0 comments Download
M src/core/SkRecorder.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/core/SkRecorder.cpp View 2 chunks +1 line, -17 lines 0 comments Download
M tests/CanvasTest.cpp View 4 chunks +1 line, -4 lines 0 comments Download
M tools/debugger/SkDebugCanvas.h View 11 chunks +19 lines, -43 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 3 chunks +0 lines, -21 lines 0 comments Download
M tools/debugger/SkDrawCommand.h View 3 chunks +0 lines, -31 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 7 chunks +1 line, -75 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vjiaoblack
Created Revert of Creating framework for drawShadowedPicture
4 years, 5 months ago (2016-07-21 16:23:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167223002/1
4 years, 5 months ago (2016-07-21 16:24:08 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 16:24:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/33d325890e549c113a258248002246b46e8040b2

Powered by Google App Engine
This is Rietveld 408576698