bluetooth: Generate random service uuid and generate random fake adapter.

bluetooth: Generate random service uuid and generate random fake adapter.

This patch includes two changes:
 1. Randomly generate a Service UUID, weighting services from the
    fake devices more heavily.
 2. Randomly pick a fake adapter to use.

Also adds a testing/clusterfuzz/fuzzers/common directory that includes modules
that are useful for other python fuzzers.

BUG=570049
Committed: https://crrev.com/b888673dadc0ca01b7cd6c5028565f4d2fe6ee3a
Cr-Commit-Position: refs/heads/master@{#407870}

[ortuno, 2016-07-20 20:09:59]

Patchset #1 (id:1) has been deleted

[ortuno, 2016-07-21 21:34:04]

Description was changed from

==========
bluetooth: Generate random service uuid and generate random fake adapter.

This patch includes two changes:
 1. Randomly generate a Service UUID, weighting services from the
    fake devices more heavily.
 2. Randomly pick a fake adapter to use.

BUG=570049
==========

to

==========
bluetooth: Generate random service uuid and generate random fake adapter.

This patch includes two changes:
 1. Randomly generate a Service UUID, weighting services from the
    fake devices more heavily.
 2. Randomly pick a fake adapter to use.

Also adds a testing/clusterfuzz/fuzzers/common directory that includes modules
that are useful for other python fuzzers.

BUG=570049
==========

[ortuno, 2016-07-21 21:34:19]

Patchset #2 (id:40001) has been deleted

[ortuno, 2016-07-21 21:34:25]

Patchset #2 (id:60001) has been deleted

[ortuno, 2016-07-21 21:35:23]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-07-21 21:35:24]

scheib: PTAL

https://codereview.chromium.org/2166913002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/bluetooth/web_bluetooth_fuzzer/constraints.py
(right):

https://codereview.chromium.org/2166913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/web_bluetooth_fuzzer/constraints.py:26:
sys.path.append(os.pardir)
On 2016/07/15 at 21:05:58, scheib wrote:
> Instead print an error that the files need to be copied, and quit/rethrow?
That way anyone trying to use it will see that they have to do something to get
it to work on server.

Now the setup.py script copies these files.

https://codereview.chromium.org/2166913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/web_bluetooth_fuzzer/constraints.py:32:
# List of services that are included in our fake adapters.
On 2016/07/15 at 21:05:58, scheib wrote:
> We should have something in our fake adapters that reminds folks to update the
fuzzer when changing the fake adapters. Maybe in
LayoutTestBluetoothAdapterProvider::GetBluetoothAdapter.

Done.

https://codereview.chromium.org/2166913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/web_bluetooth_fuzzer/constraints.py:106:
roll = random.random()
On 2016/07/15 at 21:05:58, scheib wrote:
> I am silly:
> random.choice(['random uuid', 'random number', 'fuzzed uuid string'])

Done.

[scheib, 2016-07-25 19:21:13]

LGTM but:

Add a
 testing/clusterfuzz/README.md
linking to 

https://www.chromium.org/Home/chromium-security/bugs/developing-fuzzers-for-c...


Consider testing/clusterfuzz/common, instead of the additional /fuzzers/ subdir?

https://codereview.chromium.org/2166913002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/constraints.py
(right):

https://codereview.chromium.org/2166913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/constraints.py:34:
'611c954a-263b-4f4a-aab6-01ddb953f985',  # Blacklist
# Blacklisted (created for testing)
or just
# Blacklisted

[haraken, 2016-07-25 19:22:21]

Directory structure LGTM

[ortuno, 2016-07-25 20:51:33]

Patchset #3 (id:100001) has been deleted

[ortuno, 2016-07-25 20:55:48]

ortuno@chromium.org changed reviewers:
+ haraken@chromium.org

[ortuno, 2016-07-25 20:55:49]

On 2016/07/25 at 19:21:13, scheib wrote:
> Add a
>  testing/clusterfuzz/README.md
> linking to 
> 
https://www.chromium.org/Home/chromium-security/bugs/developing-fuzzers-for-c...

Done.

> 
> 
> Consider testing/clusterfuzz/common, instead of the additional /fuzzers/
subdir?

Done.

https://codereview.chromium.org/2166913002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/constraints.py
(right):

https://codereview.chromium.org/2166913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/constraints.py:34:
'611c954a-263b-4f4a-aab6-01ddb953f985',  # Blacklist
On 2016/07/25 at 19:21:13, scheib wrote:
> # Blacklisted (created for testing)
> or just
> # Blacklisted

Done.

[ortuno, 2016-07-25 20:57:13]

ortuno@chromium.org changed reviewers:
+ mmoroz@chromium.org

[ortuno, 2016-07-25 20:57:14]

mmoroz: PTAL, note that we are open sourcing some common files for fuzzers,
cc'ing inferno and ochang who approved this.

[mmoroz, 2016-07-26 16:29:54]

LGTM

[ortuno, 2016-07-26 16:31:02]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 16:32:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:49:41]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-07-26 17:52:16]

Thanks!

[ortuno, 2016-07-26 17:52:35]

ortuno@chromium.org changed reviewers:
+ dpranke@chromium.org

[ortuno, 2016-07-26 17:52:36]

dpranke: PTAL at testing/

[Dirk Pranke, 2016-07-26 18:35:22]

lgtm

[ortuno, 2016-07-26 18:56:52]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-07-26 18:56:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2166913002/#ps140001
(title: "Address scheib's comments")

[commit-bot: I haz the power, 2016-07-26 18:57:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 19:03:12]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-07-26 19:05:13]

Description was changed from

==========
bluetooth: Generate random service uuid and generate random fake adapter.

This patch includes two changes:
 1. Randomly generate a Service UUID, weighting services from the
    fake devices more heavily.
 2. Randomly pick a fake adapter to use.

Also adds a testing/clusterfuzz/fuzzers/common directory that includes modules
that are useful for other python fuzzers.

BUG=570049
==========

to

==========
bluetooth: Generate random service uuid and generate random fake adapter.

This patch includes two changes:
 1. Randomly generate a Service UUID, weighting services from the
    fake devices more heavily.
 2. Randomly pick a fake adapter to use.

Also adds a testing/clusterfuzz/fuzzers/common directory that includes modules
that are useful for other python fuzzers.

BUG=570049

Committed: https://crrev.com/b888673dadc0ca01b7cd6c5028565f4d2fe6ee3a
Cr-Commit-Position: refs/heads/master@{#407870}
==========

[commit-bot: I haz the power, 2016-07-26 19:05:15]

Patchset 4 (id:??) landed as
https://crrev.com/b888673dadc0ca01b7cd6c5028565f4d2fe6ee3a
Cr-Commit-Position: refs/heads/master@{#407870}