Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2166463002: bluetooth: Basic Web Bluetooth Fuzzer (Closed)

Created:
4 years, 5 months ago by ortuno
Modified:
4 years, 5 months ago
Reviewers:
scheib
CC:
blink-reviews, chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org, Oliver Chang, mmoroz, inferno
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Basic Web Bluetooth Fuzzer Adds basic structure of the fuzzer, a base template and some tests. The fuzzer in this file uses two variations of calls to requestDevice to generate a random sequence of calls. It then replaces instances of 'TRANSFORM_REQUEST_DEVICE_OPTIONS' with object with a single filter with a single random service. BUG=570049 Committed: https://crrev.com/381085b764c743ca32c64168e1f0337050179d03 Cr-Commit-Position: refs/heads/master@{#406940}

Patch Set 1 #

Patch Set 2 : Introduce setup script #

Patch Set 3 : Improve readme and setup.py #

Patch Set 4 : Move to testing/clusterfuzz directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+567 lines, -0 lines) Patch
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/.gitignore View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/PRESUBMIT.py View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/README.md View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/constraints.py View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/constraints_unittest.py View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/fuzz_integration_test.py View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/fuzz_main_run.py View 1 2 3 1 chunk +166 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/fuzzer_helpers.py View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/parameter_fuzzer.py View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/setup.py View 1 2 3 1 chunk +104 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/templates/base-template.html View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/test_case_fuzzer.py View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (15 generated)
ortuno
scheib: PTAL. The first patchset is just a copy https://chromereviews.googleplex.com/455837013/#ps240001 but formatted to adhere to ...
4 years, 5 months ago (2016-07-20 17:36:56 UTC) #9
haraken
Drive-by: I'd prefer putting those files in Tools/Scripts/webkitpy/ or somewhere though.
4 years, 5 months ago (2016-07-20 17:48:50 UTC) #10
scheib
w.r.t. path locations, I've started an email thread on platform-architecture-dev, as discussed with haraken. https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/rh8wARwNcFQ/discussion ...
4 years, 5 months ago (2016-07-20 20:10:37 UTC) #11
scheib
Consensus seems to be reached, LGTM with files moved to a subdir of modules/bluetooth/testing/ Perhaps ...
4 years, 5 months ago (2016-07-21 16:04:20 UTC) #12
ortuno
On 2016/07/21 at 16:04:20, scheib wrote: > Consensus seems to be reached, LGTM with files ...
4 years, 5 months ago (2016-07-21 21:05:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166463002/120001
4 years, 5 months ago (2016-07-21 21:06:35 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:120001)
4 years, 5 months ago (2016-07-21 21:14:02 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:17:27 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/381085b764c743ca32c64168e1f0337050179d03
Cr-Commit-Position: refs/heads/master@{#406940}

Powered by Google App Engine
This is Rietveld 408576698