bluetooth: fuzzer: Add a connect and getPrimaryServices tokens

bluetooth: fuzzer: Add a connect and getPrimaryServices tokens

* Adds the catch token. This increases the likelihood of generating valid test
  cases since the test cases will no longer immediately fail.
* Adds connect and getPrimaryServices tokens.
* Introduce the concept of "base" tokens. After adding the connect and
  getPrimaryServices tokens the chances of generating valid test cases decreased
  dramatically (0.29% of producing a test case which tried to retrieve services).
  Base tokens increase the likelihood of generating valid test cases by starting
  a test with a known valid sequence of operations.
* Also changes fakes to default to connection error. Otherwise they would just drop
  connect calls causing crashes.

BUG=570049
Committed: https://crrev.com/d0b52049f302ec50cf7f53b77bca193948d7b735
Cr-Commit-Position: refs/heads/master@{#408034}

[ortuno, 2016-07-25 21:50:02]

Description was changed from

==========
bluetooth: Add a connect and getPrimaryServices tokens

BUG=570049
==========

to

==========
bluetooth: Add a connect and getPrimaryServices tokens

* Adds the catch token. This increases the likelihood of generating valid test
  cases since the test cases will no longer immediately fail.
* Adds connect and getPrimaryServices tokens.
* Introduce the concept of "base" tokens. After adding the connect and
  getPrimaryServices tokens the chances of generating valid test cases decreased
  dramatically (0.29% of producing a test case which tried to retrieve
services).
  Base tokens increase the likelihood of generating valid test cases by starting
  a test with a known valid sequence of operations.

BUG=570049
==========

[ortuno, 2016-07-25 21:51:56]

Description was changed from

==========
bluetooth: Add a connect and getPrimaryServices tokens

* Adds the catch token. This increases the likelihood of generating valid test
  cases since the test cases will no longer immediately fail.
* Adds connect and getPrimaryServices tokens.
* Introduce the concept of "base" tokens. After adding the connect and
  getPrimaryServices tokens the chances of generating valid test cases decreased
  dramatically (0.29% of producing a test case which tried to retrieve
services).
  Base tokens increase the likelihood of generating valid test cases by starting
  a test with a known valid sequence of operations.

BUG=570049
==========

to

==========
bluetooth: Add a connect and getPrimaryServices tokens

* Adds the catch token. This increases the likelihood of generating valid test
  cases since the test cases will no longer immediately fail.
* Adds connect and getPrimaryServices tokens.
* Introduce the concept of "base" tokens. After adding the connect and
  getPrimaryServices tokens the chances of generating valid test cases decreased
  dramatically (0.29% of producing a test case which tried to retrieve
services).
  Base tokens increase the likelihood of generating valid test cases by starting
  a test with a known valid sequence of operations.
* Also changes fakes to default to connection error. Otherwise they would just
drop
  connect calls causing crashes.

BUG=570049
==========

[ortuno, 2016-07-25 21:52:54]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-07-25 21:52:54]

scheib: PTAL

[scheib, 2016-07-26 18:02:25]

Description was changed from

==========
bluetooth: Add a connect and getPrimaryServices tokens

* Adds the catch token. This increases the likelihood of generating valid test
  cases since the test cases will no longer immediately fail.
* Adds connect and getPrimaryServices tokens.
* Introduce the concept of "base" tokens. After adding the connect and
  getPrimaryServices tokens the chances of generating valid test cases decreased
  dramatically (0.29% of producing a test case which tried to retrieve
services).
  Base tokens increase the likelihood of generating valid test cases by starting
  a test with a known valid sequence of operations.
* Also changes fakes to default to connection error. Otherwise they would just
drop
  connect calls causing crashes.

BUG=570049
==========

to

==========
bluetooth: fuzzer: Add a connect and getPrimaryServices tokens

* Adds the catch token. This increases the likelihood of generating valid test
  cases since the test cases will no longer immediately fail.
* Adds connect and getPrimaryServices tokens.
* Introduce the concept of "base" tokens. After adding the connect and
  getPrimaryServices tokens the chances of generating valid test cases decreased
  dramatically (0.29% of producing a test case which tried to retrieve
services).
  Base tokens increase the likelihood of generating valid test cases by starting
  a test with a known valid sequence of operations.
* Also changes fakes to default to connection error. Otherwise they would just
drop
  connect calls causing crashes.

BUG=570049
==========

[scheib, 2016-07-26 19:04:44]

LGTM, with suggestion:

https://codereview.chromium.org/2178853006/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/constraints.py
(right):

https://codereview.chromium.org/2178853006/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/constraints.py:26:
# Strings that are used at the beginning of a test.
Comment that these are going to have parameters filled in below, so they have
arguments.
As discussed, 'print' and optionally named parameters may make this code more
readable & reduce errors (parameters must match intention).

print ("setBluetoothFakeAdapter(%(FAKENAME)s) {}" % { 'FAKENAME':'frobber'})

[ortuno, 2016-07-26 20:59:48]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 21:00:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 00:16:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 00:16:05]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ortuno, 2016-07-27 02:27:18]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-07-27 02:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2178853006/#ps20001
(title: "Format")

[commit-bot: I haz the power, 2016-07-27 02:27:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 03:29:11]

Description was changed from

==========
bluetooth: fuzzer: Add a connect and getPrimaryServices tokens

* Adds the catch token. This increases the likelihood of generating valid test
  cases since the test cases will no longer immediately fail.
* Adds connect and getPrimaryServices tokens.
* Introduce the concept of "base" tokens. After adding the connect and
  getPrimaryServices tokens the chances of generating valid test cases decreased
  dramatically (0.29% of producing a test case which tried to retrieve
services).
  Base tokens increase the likelihood of generating valid test cases by starting
  a test with a known valid sequence of operations.
* Also changes fakes to default to connection error. Otherwise they would just
drop
  connect calls causing crashes.

BUG=570049
==========

to

==========
bluetooth: fuzzer: Add a connect and getPrimaryServices tokens

* Adds the catch token. This increases the likelihood of generating valid test
  cases since the test cases will no longer immediately fail.
* Adds connect and getPrimaryServices tokens.
* Introduce the concept of "base" tokens. After adding the connect and
  getPrimaryServices tokens the chances of generating valid test cases decreased
  dramatically (0.29% of producing a test case which tried to retrieve
services).
  Base tokens increase the likelihood of generating valid test cases by starting
  a test with a known valid sequence of operations.
* Also changes fakes to default to connection error. Otherwise they would just
drop
  connect calls causing crashes.

BUG=570049
==========

[commit-bot: I haz the power, 2016-07-27 03:29:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 03:32:52]

Description was changed from

==========
bluetooth: fuzzer: Add a connect and getPrimaryServices tokens

* Adds the catch token. This increases the likelihood of generating valid test
  cases since the test cases will no longer immediately fail.
* Adds connect and getPrimaryServices tokens.
* Introduce the concept of "base" tokens. After adding the connect and
  getPrimaryServices tokens the chances of generating valid test cases decreased
  dramatically (0.29% of producing a test case which tried to retrieve
services).
  Base tokens increase the likelihood of generating valid test cases by starting
  a test with a known valid sequence of operations.
* Also changes fakes to default to connection error. Otherwise they would just
drop
  connect calls causing crashes.

BUG=570049
==========

to

==========
bluetooth: fuzzer: Add a connect and getPrimaryServices tokens

* Adds the catch token. This increases the likelihood of generating valid test
  cases since the test cases will no longer immediately fail.
* Adds connect and getPrimaryServices tokens.
* Introduce the concept of "base" tokens. After adding the connect and
  getPrimaryServices tokens the chances of generating valid test cases decreased
  dramatically (0.29% of producing a test case which tried to retrieve
services).
  Base tokens increase the likelihood of generating valid test cases by starting
  a test with a known valid sequence of operations.
* Also changes fakes to default to connection error. Otherwise they would just
drop
  connect calls causing crashes.

BUG=570049

Committed: https://crrev.com/d0b52049f302ec50cf7f53b77bca193948d7b735
Cr-Commit-Position: refs/heads/master@{#408034}
==========

[commit-bot: I haz the power, 2016-07-27 03:32:53]

Patchset 2 (id:??) landed as
https://crrev.com/d0b52049f302ec50cf7f53b77bca193948d7b735
Cr-Commit-Position: refs/heads/master@{#408034}

[ortuno, 2016-07-28 22:26:22]

Oops. Just realized that I submitting before sending drafts.

https://codereview.chromium.org/2178853006/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/constraints.py
(right):

https://codereview.chromium.org/2178853006/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/constraints.py:26:
# Strings that are used at the beginning of a test.
On 2016/07/26 at 19:04:44, scheib wrote:
> Comment that these are going to have parameters filled in below, so they have
arguments.
> As discussed, 'print' and optionally named parameters may make this code more
readable & reduce errors (parameters must match intention).
> 
> print ("setBluetoothFakeAdapter(%(FAKENAME)s) {}" % { 'FAKENAME':'frobber'})

I added names to the parameters but I kept format given the warning on %'s
documentation[1]:

"The formatting operations described here are obsolete and may go away in future
versions of Python. Use the new String Formatting in new code."

[1]
https://docs.python.org/release/3.1.5/library/stdtypes.html#old-string-format...