chrome/browser/ui/global_error/global_error.cc - Issue 2166853002: Reverse error and warning icons on app menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/global_error/global_error.cc

Issue 2166853002: Reverse error and warning icons on app menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed warning icon and made all remaining browser_tools icons 1x (16x16) by default Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/global_error/global_error.cc

diff --git a/chrome/browser/ui/global_error/global_error.cc b/chrome/browser/ui/global_error/global_error.cc

index 87645c41835e7c1e47c888cba51f897b9e47c6d3..601513d7981e1f2b41ebdfc11d0fe9524d125667 100644

--- a/chrome/browser/ui/global_error/global_error.cc

+++ b/chrome/browser/ui/global_error/global_error.cc

@@ -30,8 +30,8 @@ gfx::Image GlobalError::MenuItemIcon() {

return ResourceBundle::GetSharedInstance().GetNativeImageNamed(

IDR_INPUT_ALERT_MENU);

Evan Stade 2016/07/21 17:28:43 might be worth pinging shrike to see if mac should

#else

- return gfx::Image(gfx::CreateVectorIcon(gfx::VectorIconId::WARNING, 18,

- gfx::kGoogleYellow700));

+ return gfx::Image(gfx::CreateVectorIcon(

+ gfx::VectorIconId::BROWSER_TOOLS_ERROR, gfx::kGoogleYellow700));

#endif

}