chrome/browser/ui/views/toolbar/app_menu_button.cc - Issue 2166853002: Reverse error and warning icons on app menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/app_menu_button.cc

Issue 2166853002: Reverse error and warning icons on app menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed warning icon and made all remaining browser_tools icons 1x (16x16) by default Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/app_menu_button.cc

diff --git a/chrome/browser/ui/views/toolbar/app_menu_button.cc b/chrome/browser/ui/views/toolbar/app_menu_button.cc

index 7ca27a72b422d3ae8dddfad6d1c2e67d30de7731..a83f91a934d1f4cdd8db3d426f48ea9979b15421 100644

--- a/chrome/browser/ui/views/toolbar/app_menu_button.cc

+++ b/chrome/browser/ui/views/toolbar/app_menu_button.cc

@@ -166,10 +166,8 @@ void AppMenuButton::UpdateIcon() {

icon_id = gfx::VectorIconId::BROWSER_TOOLS_UPDATE;

break;

case AppMenuIconController::IconType::GLOBAL_ERROR:

- icon_id = gfx::VectorIconId::BROWSER_TOOLS_ERROR;

- break;

case AppMenuIconController::IconType::INCOMPATIBILITY_WARNING:

- icon_id = gfx::VectorIconId::BROWSER_TOOLS_WARNING;

+ icon_id = gfx::VectorIconId::BROWSER_TOOLS_ERROR;

break;

}