Reverse error and warning icons on app menu.

chrome/browser/ui/global_error/global_error.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/global_error/global_error.h"
 
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "chrome/browser/ui/global_error/global_error_bubble_view_base.h"
 #include "grit/theme_resources.h"
@@ skipping 10 matching lines @@
 
 GlobalError::GlobalError() {}
 
 GlobalError::~GlobalError() {}
 
 GlobalError::Severity GlobalError::GetSeverity() { return SEVERITY_MEDIUM; }
 
 gfx::Image GlobalError::MenuItemIcon() {
 #if defined(OS_MACOSX) || defined(OS_ANDROID)
   return ResourceBundle::GetSharedInstance().GetNativeImageNamed(
       IDR_INPUT_ALERT_MENU);

[Evan Stade, 2016/07/21 17:28:43]

might be worth pinging shrike to see if mac should be using the same thing as
windows here (non-blocking to this cl of course)

 #else
-  return gfx::Image(gfx::CreateVectorIcon(gfx::VectorIconId::WARNING, 18,
-                                          gfx::kGoogleYellow700));
+  return gfx::Image(gfx::CreateVectorIcon(
+      gfx::VectorIconId::BROWSER_TOOLS_ERROR, gfx::kGoogleYellow700));
 #endif
 }
 
 // GlobalErrorWithStandardBubble ---------------------------------------------
 
 GlobalErrorWithStandardBubble::GlobalErrorWithStandardBubble()
     : has_shown_bubble_view_(false), bubble_view_(NULL) {}
 
 GlobalErrorWithStandardBubble::~GlobalErrorWithStandardBubble() {}
 
@@ skipping 30 matching lines @@
 
 bool GlobalErrorWithStandardBubble::ShouldAddElevationIconToAcceptButton() {
   return false;
 }
 
 void GlobalErrorWithStandardBubble::BubbleViewDidClose(Browser* browser) {
   DCHECK(browser);
   bubble_view_ = NULL;
   OnBubbleViewDidClose(browser);
 }