Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2166833003: Revert of [telemetry] Trace config should be used to disable periodic dumps (Closed)

Created:
4 years, 5 months ago by ssid
Modified:
4 years, 1 month ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, perezju
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [telemetry] Trace config should be used to disable periodic dumps (patchset #1 id:1 of https://codereview.chromium.org/2162283002/ ) Reason for revert: Looks like some reference builds still haven't got the devtools api update. Original issue's description: > [telemetry] Trace config should be used to disable periodic dumps > > Telemetry previously used the "--enable-memory-benchmarking" flag to > tell memory dump manager to disable periodic dumps. That is cleaned up > in this CL and the trace config is used to achieve this behavior. > > Note to perf sheriff: Memory benchmarks could regress if the config > did not propagate correctly. > > BUG=513692 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6 > Cr-Commit-Position: refs/heads/master@{#406598} TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629988, 513692 Committed: https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 Cr-Commit-Position: refs/heads/master@{#406691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 4 chunks +7 lines, -7 lines 0 comments Download
M tools/perf/benchmarks/oortonline.py View 3 chunks +7 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/system_health.py View 2 chunks +7 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/v8.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ssid
Created Revert of [telemetry] Trace config should be used to disable periodic dumps
4 years, 5 months ago (2016-07-20 22:20:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166833003/1
4 years, 5 months ago (2016-07-20 22:22:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 22:23:54 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aad3e5da6864138469892f1459137e19a0cd5e26 Cr-Commit-Position: refs/heads/master@{#406691}
4 years, 5 months ago (2016-07-20 22:26:19 UTC) #9
ssid
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2458413002/ by ssid@chromium.org. ...
4 years, 1 month ago (2016-10-31 04:32:17 UTC) #10
Primiano Tucci (use gerrit)
On 2016/10/31 04:32:17, ssid wrote: > A revert of this CL (patchset #1 id:1) has ...
4 years, 1 month ago (2016-11-01 15:09:37 UTC) #11
ssid
4 years, 1 month ago (2016-11-03 08:00:01 UTC) #12
Message was sent while issue was closed.
On 2016/11/01 15:09:37, Primiano Tucci wrote:
> On 2016/10/31 04:32:17, ssid wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2458413002/ by mailto:ssid@chromium.org.
> > 
> > The reason for reverting is: Reference build was rolled, Issue 629987..
> 
> Uh I got a bit lost here between revert and failed reland.
> Any summary of what's the current state?

I explained in https://codereview.chromium.org/2458413002#msg9.

Powered by Google App Engine
This is Rietveld 408576698