Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/perf/benchmarks/oortonline.py

Issue 2166833003: Revert of [telemetry] Trace config should be used to disable periodic dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/memory_infra.py ('k') | tools/perf/benchmarks/system_health.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/oortonline.py
diff --git a/tools/perf/benchmarks/oortonline.py b/tools/perf/benchmarks/oortonline.py
index be3ace0ac4bcf20a0825c68c999c693c26d3dac4..984cef0a2a7584be03054fc394d719d7753a60e8 100644
--- a/tools/perf/benchmarks/oortonline.py
+++ b/tools/perf/benchmarks/oortonline.py
@@ -10,7 +10,6 @@
from telemetry.value import scalar
from telemetry.value import improvement_direction
from telemetry.timeline import chrome_trace_category_filter
-from telemetry.timeline import chrome_trace_config
from telemetry.web_perf import timeline_based_measurement
from telemetry.web_perf.metrics import v8_gc_latency
from telemetry.web_perf.metrics import smoothness
@@ -60,6 +59,13 @@
Info: http://v8project.blogspot.de/2015/10/jank-busters-part-one.html
"""
+ def SetExtraBrowserOptions(self, options):
+ options.AppendExtraBrowserArgs([
+ # TODO(perezju): Temporary workaround to disable periodic memory dumps.
+ # See: http://crbug.com/513692
+ '--enable-memory-benchmarking',
+ ])
+
def CreateStorySet(self, options):
return page_sets.OortOnlineTBMPageSet()
@@ -78,9 +84,6 @@
options.SetLegacyTimelineBasedMetrics([v8_gc_latency.V8GCLatency(),
smoothness.SmoothnessMetric(),
memory_timeline.MemoryTimelineMetric()])
- # Setting an empty memory dump config disables periodic dumps.
- options.config.chrome_trace_config.SetMemoryDumpConfig(
- chrome_trace_config.MemoryDumpConfig())
return options
@classmethod
« no previous file with comments | « tools/perf/benchmarks/memory_infra.py ('k') | tools/perf/benchmarks/system_health.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698