Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2166643003: [Subzero][MIPS32] Fix stack offset assignment of spilled variables on MIPS32 (Closed)

Created:
4 years, 5 months ago by sagar.thakur
Modified:
4 years, 5 months ago
Reviewers:
srdjan.obucina, Eric Holk, Karl, Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com, jaydeep.patil, mohit.bhakkad, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -5 lines) Patch
M src/IceTargetLoweringMIPS32.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 3 chunks +45 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sagar.thakur
4 years, 5 months ago (2016-07-20 07:01:34 UTC) #2
Jim Stichnoth
lgtm
4 years, 5 months ago (2016-07-21 13:12:00 UTC) #3
Jim Stichnoth
4 years, 5 months ago (2016-07-21 13:12:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
752e59fa202c71742c6ca001e28aade2296c292d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698