chrome/test/BUILD.gn - Issue 2166573003: Track TextInputState from multiple RenderWidgets in TextInputManager (Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/BUILD.gn

Issue 2166573003: Track TextInputState from multiple RenderWidgets in TextInputManager (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: GetTextInputType() must be public to be accessed by the Cocoa view Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('K') | « chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('k') | content/browser/renderer_host/render_widget_host_view_base.cc » ('j') | content/browser/renderer_host/render_widget_host_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/BUILD.gn

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn

index 9d68d7bf05a4b23379d09ef6a6b6fb3f470cd50e..ce9c0db3fa339f767dee3592ed3c3164c8da6f0a 100644

--- a/chrome/test/BUILD.gn

+++ b/chrome/test/BUILD.gn

@@ -481,7 +481,7 @@ if (!is_android) {

"../../ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc",

]

}

- if (use_aura) {

+ if (use_aura || is_mac) {

# TODO(ekaramad): These tests are activated for aura only. They should

kenrb 2016/07/21 21:48:16 nit: Comment needs update.

EhsanK 2016/07/25 17:12:02 Acknowledged.

# be moved to 'interactive_ui_tests' sources for all platforms once bug

# 578168 is fixed.