Track TextInputState from multiple RenderWidgets in TextInputManager (Mac)

chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

Index: chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
diff --git a/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc b/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
index f9923d4ae98a2907bd0c06c0a57fe7a4b750af0f..95c753a0d6a308a1f577c760ebc404857c426005 100644
--- a/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
+++ b/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
@@ -506,6 +506,9 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
   reset_state_observer.Wait();
 }
 
+// TODO(ekaramad): Enable the following tests on other platforms when the
+// corresponding feature is implemented (http://crbug.com/578168).

[kenrb, 2016/07/21 21:48:16]

Is it much extra to implement all of it in this CL? It appears to be just a few
more changes to RenderWidgetHostViewMac.

[Charlie Reis, 2016/07/22 20:59:35]

I'm ok either way, but I have a slight preference to do it incrementally like
this.  The smaller CLs have been easy to review when they have less going on
(assuming the intermediate stages are safe).

[EhsanK, 2016/07/25 17:12:02]

I have fixes for some of the other IME-related tracking in Mac but not all. I
figured 1) make CLs small and 2) land changes asap so that I can catch
regressions sooner. My own suggestion is to have at least TextInputState
tracking on a different CL. I guess I will be able to manage to fit all the
other state trackings in one CL.

That being said I guess I should be able to have one CL for all of Mac by the
end of the week if that is the direction we are going.

[Charlie Reis, 2016/07/25 19:43:55]

Let's keep the CLs small and proceed incrementally if possible.

+#if defined(USE_AURA)
 // This test creates a page with multiple child frames and adds an <input> to
 // each frame. Then, sequentially, each <input> is focused by sending a tab key.
 // Then, after |TextInputState.type| for a view is changed to text, another key
@@ -581,11 +584,13 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
   for (auto view : views)
     send_tab_set_composition_wait_for_bounds_change(view);
 }
+#endif  // USE_AURA
 
 // TODO(ekaramad): The following tests are specifically written for Aura and are
 // based on InputMethodObserver. Write similar tests for Mac/Android/Mus
 // (crbug.com/602723).
 
+#if defined(USE_AURA)
 // Observes current input method for state changes.
 class InputMethodObserverBase {
  public:
@@ -691,3 +696,4 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
   sender.SetType(ui::TEXT_INPUT_TYPE_NONE);
   EXPECT_FALSE(send_and_check_show_ime());
 }
+#endif