content/browser/renderer_host/render_widget_host_view_base.cc - Issue 2166573003: Track TextInputState from multiple RenderWidgets in TextInputManager (Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2166573003: Track TextInputState from multiple RenderWidgets in TextInputManager (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: GetTextInputType() must be public to be accessed by the Cocoa view Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/BUILD.gn ('K') | « chrome/test/BUILD.gn ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc

index b9bcafc640e9a105f1cd93d2b6e7129760df01cb..a627074c96cf3d9892cc36851447fee02c728295 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.cc

+++ b/content/browser/renderer_host/render_widget_host_view_base.cc

@@ -403,7 +403,7 @@ void RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(

void RenderWidgetHostViewBase::TextInputStateChanged(

const TextInputState& text_input_state) {

// TODO(ekaramad): Use TextInputManager code paths for IME on other platforms.

-#if defined(USE_AURA)

+#if defined(USE_AURA) || defined(OS_MACOSX)

kenrb 2016/07/21 21:48:16 Should this be replaced with #if !defined(OS_ANDRO

EhsanK 2016/07/25 17:12:02 Done. I guess I was just being very specific.

if (GetTextInputManager())

GetTextInputManager()->UpdateTextInputState(this, text_input_state);

#endif