Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 2166563003: Split //blimp/client/core to relevant parts. (Closed)

Created:
4 years, 5 months ago by nyquist
Modified:
4 years, 5 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-assignment-source
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split //blimp/client/core to relevant parts. Currently //blimp/client/core is a target that contains everything that exists in that directory and subdirectories. This CL changes the structure so that only the BlimpClientContextImpl and the command line switches are left in the top-level core directory. In addition to moving files to their own directories, the change also adds BUILD.gn files to their respective directories, both for C++ and Java. BUG=611097 Committed: https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59 Cr-Commit-Position: refs/heads/master@{#406402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -1440 lines) Patch
M blimp/client/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D blimp/client/app/android/javatests/src/org/chromium/blimp/core/BlimpContentsTest.java View 1 chunk +0 lines, -93 lines 0 comments Download
A + blimp/client/app/android/javatests/src/org/chromium/blimp/core/contents/BlimpContentsTest.java View 1 chunk +4 lines, -4 lines 0 comments Download
M blimp/client/core/BUILD.gn View 4 chunks +55 lines, -53 lines 0 comments Download
M blimp/client/core/android/blimp_client_context_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
D blimp/client/core/android/blimp_contents_factory.h View 1 chunk +0 lines, -20 lines 0 comments Download
D blimp/client/core/android/blimp_contents_factory.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D blimp/client/core/android/blimp_contents_impl_android.h View 1 chunk +0 lines, -43 lines 0 comments Download
D blimp/client/core/android/blimp_contents_impl_android.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D blimp/client/core/android/blimp_contents_observer_proxy.h View 1 chunk +0 lines, -44 lines 0 comments Download
D blimp/client/core/android/blimp_contents_observer_proxy.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M blimp/client/core/android/blimp_jni_registrar.cc View 2 chunks +2 lines, -9 lines 0 comments Download
D blimp/client/core/android/blimp_navigation_controller_impl_android.h View 1 chunk +0 lines, -47 lines 0 comments Download
D blimp/client/core/android/blimp_navigation_controller_impl_android.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java View 1 chunk +1 line, -1 line 0 comments Download
D blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsFactory.java View 1 chunk +0 lines, -27 lines 0 comments Download
D blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsImpl.java View 1 chunk +0 lines, -83 lines 0 comments Download
D blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsObserverProxy.java View 1 chunk +0 lines, -53 lines 0 comments Download
D blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpNavigationControllerImpl.java View 1 chunk +0 lines, -54 lines 0 comments Download
M blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/blimp_client_context_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/blimp_client_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/blimp_client_context_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D blimp/client/core/blimp_contents_impl.h View 1 chunk +0 lines, -63 lines 0 comments Download
D blimp/client/core/blimp_contents_impl.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D blimp/client/core/blimp_contents_impl_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D blimp/client/core/blimp_navigation_controller_delegate.h View 1 chunk +0 lines, -33 lines 0 comments Download
D blimp/client/core/blimp_navigation_controller_impl.h View 1 chunk +0 lines, -54 lines 0 comments Download
D blimp/client/core/blimp_navigation_controller_impl.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D blimp/client/core/blimp_navigation_controller_impl_unittest.cc View 1 chunk +0 lines, -49 lines 0 comments Download
A blimp/client/core/contents/BUILD.gn View 1 chunk +95 lines, -0 lines 0 comments Download
A + blimp/client/core/contents/android/blimp_contents_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/contents/android/blimp_contents_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + blimp/client/core/contents/android/blimp_contents_impl_android.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + blimp/client/core/contents/android/blimp_contents_impl_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A blimp/client/core/contents/android/blimp_contents_jni_registrar.h View 1 chunk +19 lines, -0 lines 0 comments Download
A + blimp/client/core/contents/android/blimp_contents_jni_registrar.cc View 2 chunks +6 lines, -13 lines 0 comments Download
A + blimp/client/core/contents/android/blimp_contents_observer_proxy.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + blimp/client/core/contents/android/blimp_contents_observer_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + blimp/client/core/contents/android/blimp_navigation_controller_impl_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsFactory.java View 1 chunk +2 lines, -2 lines 0 comments Download
A + blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java View 1 chunk +4 lines, -4 lines 0 comments Download
A + blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpContentsObserverProxy.java View 1 chunk +2 lines, -2 lines 0 comments Download
A + blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java View 1 chunk +2 lines, -2 lines 0 comments Download
A + blimp/client/core/contents/blimp_contents_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + blimp/client/core/contents/blimp_contents_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + blimp/client/core/contents/blimp_contents_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + blimp/client/core/contents/blimp_navigation_controller_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/contents/blimp_navigation_controller_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + blimp/client/core/contents/blimp_navigation_controller_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M blimp/client/core/dummy_blimp_client_context.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/public/BUILD.gn View 2 chunks +8 lines, -8 lines 0 comments Download
M blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java View 1 chunk +2 lines, -0 lines 0 comments Download
D blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpContents.java View 1 chunk +0 lines, -37 lines 0 comments Download
D blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java View 1 chunk +0 lines, -19 lines 0 comments Download
D blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpNavigationController.java View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/client/public/android/java/src/org/chromium/blimp_public/EmptyBlimpContentsObserver.java View 1 chunk +0 lines, -15 lines 0 comments Download
A + blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContents.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpContentsObserver.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/public/android/java/src/org/chromium/blimp_public/contents/BlimpNavigationController.java View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/public/android/java/src/org/chromium/blimp_public/contents/EmptyBlimpContentsObserver.java View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/public/blimp_client_context.h View 1 chunk +1 line, -1 line 0 comments Download
D blimp/client/public/blimp_contents.h View 1 chunk +0 lines, -42 lines 0 comments Download
D blimp/client/public/blimp_contents_observer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D blimp/client/public/blimp_navigation_controller.h View 1 chunk +0 lines, -42 lines 0 comments Download
A + blimp/client/public/contents/blimp_contents.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/public/contents/blimp_contents_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/public/contents/blimp_navigation_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/blimp/blimp_contents_profile_attachment.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
nyquist
dtrainor: PTAL
4 years, 5 months ago (2016-07-19 20:03:31 UTC) #4
David Trainor- moved to gerrit
lgtm. I'm fine with this move.
4 years, 5 months ago (2016-07-19 21:05:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166563003/1
4 years, 5 months ago (2016-07-19 22:33:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 22:40:19 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 22:40:24 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 22:43:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50130784a7a599bc33427b5ffc19d1277b556a59
Cr-Commit-Position: refs/heads/master@{#406402}

Powered by Google App Engine
This is Rietveld 408576698