Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 2157133003: Move blimp AssignmentSource to core (Closed)

Created:
4 years, 5 months ago by nyquist
Modified:
4 years, 5 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-blimp-client-switches-to-core
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move blimp AssignmentSource to core The assignment source is an internal detail of Blimp and does not have to have a public API. It is used by the BlimpClientSession, and in the process of converting that to have a public API, moving the source to the internal core folder is one step on the way towards that goal. This temporarily splits up the session-target in blimp, as the BlimpClientSession continues to stay in //blimp/client/session. BUG=611097 Committed: https://crrev.com/149198074adf37cbda2f834901059728d3ad6342 Cr-Commit-Position: refs/heads/master@{#406399}

Patch Set 1 #

Patch Set 2 : Fix path to test data #

Patch Set 3 : Create separate target for session unit tests #

Patch Set 4 : add missing dependency #

Patch Set 5 : fix public_deps for core:session #

Patch Set 6 : merge master #

Patch Set 7 : track master #

Patch Set 8 : move to session subdirectory #

Patch Set 9 : move and rename srcjar dependency #

Patch Set 10 : Fix gn checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -983 lines) Patch
M blimp/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/BUILD.gn View 1 2 3 4 5 6 7 8 9 7 chunks +5 lines, -46 lines 0 comments Download
M blimp/client/app/android/blimp_client_session_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/session/BlimpClientSession.java View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/linux/blimp_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
A blimp/client/core/session/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +78 lines, -0 lines 0 comments Download
A + blimp/client/core/session/assignment_source.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + blimp/client/core/session/assignment_source.cc View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/session/assignment_source_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + blimp/client/core/session/test_selfsigned_cert.pem View 0 chunks +-1 lines, --1 lines 0 comments Download
D blimp/client/session/assignment_source.h View 1 chunk +0 lines, -132 lines 0 comments Download
D blimp/client/session/assignment_source.cc View 1 chunk +0 lines, -381 lines 0 comments Download
D blimp/client/session/assignment_source_unittest.cc View 1 chunk +0 lines, -400 lines 0 comments Download
M blimp/client/session/blimp_client_session.h View 1 chunk +1 line, -1 line 0 comments Download
D blimp/client/session/test_selfsigned_cert.pem View 1 chunk +0 lines, -11 lines 0 comments Download
M blimp/engine/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/browser_tests/blimp_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/browser_tests/engine_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (21 generated)
nyquist
dtrainor: PTAL
4 years, 5 months ago (2016-07-18 21:21:56 UTC) #2
David Trainor- moved to gerrit
lgtm. Is the next step to tie the connect and/or token into the delegate?
4 years, 5 months ago (2016-07-19 15:05:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157133003/170001
4 years, 5 months ago (2016-07-19 19:47:29 UTC) #23
commit-bot: I haz the power
Committed patchset #10 (id:170001)
4 years, 5 months ago (2016-07-19 22:29:38 UTC) #24
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 22:30:05 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 22:31:26 UTC) #27
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/149198074adf37cbda2f834901059728d3ad6342
Cr-Commit-Position: refs/heads/master@{#406399}

Powered by Google App Engine
This is Rietveld 408576698