Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2160363002: Move ImageSerializationProcessor code to blimp/client/core (Closed)

Created:
4 years, 5 months ago by nyquist
Modified:
4 years, 5 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@split-blimp-client-core
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ImageSerializationProcessor code to blimp/client/core The ImageSerializationProcessor and related code is necessary to move to //blimp/client/core/compositor, since the BlimpClientSession needs it, and it will itself move to //blimp/client/core/session in an upcoming CL. BUG=611097 Committed: https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e Cr-Commit-Position: refs/heads/master@{#406407}

Patch Set 1 #

Patch Set 2 : fix public_deps for //blimp/test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -697 lines) Patch
M blimp/client/BUILD.gn View 7 chunks +4 lines, -9 lines 0 comments Download
M blimp/client/app/blimp_startup.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A blimp/client/core/compositor/BUILD.gn View 1 chunk +48 lines, -0 lines 0 comments Download
A + blimp/client/core/compositor/blimp_client_picture_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/compositor/blimp_client_picture_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/compositor/blimp_client_picture_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/compositor/blimp_image_decoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/compositor/blimp_image_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
A + blimp/client/core/compositor/blob_image_serialization_processor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/compositor/blob_image_serialization_processor.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/compositor/decoding_image_generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + blimp/client/core/compositor/decoding_image_generator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D blimp/client/feature/compositor/blimp_client_picture_cache.h View 1 chunk +0 lines, -84 lines 0 comments Download
D blimp/client/feature/compositor/blimp_client_picture_cache.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D blimp/client/feature/compositor/blimp_client_picture_cache_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D blimp/client/feature/compositor/blimp_image_decoder.h View 1 chunk +0 lines, -23 lines 0 comments Download
D blimp/client/feature/compositor/blimp_image_decoder.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D blimp/client/feature/compositor/blob_image_serialization_processor.h View 1 chunk +0 lines, -84 lines 0 comments Download
D blimp/client/feature/compositor/blob_image_serialization_processor.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D blimp/client/feature/compositor/decoding_image_generator.h View 1 chunk +0 lines, -48 lines 0 comments Download
D blimp/client/feature/compositor/decoding_image_generator.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M blimp/client/session/blimp_client_session.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/test/BUILD.gn View 1 1 chunk +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
nyquist
dtrainor: PTAL
4 years, 5 months ago (2016-07-19 20:04:00 UTC) #3
David Trainor- moved to gerrit
lgtm
4 years, 5 months ago (2016-07-19 21:07:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160363002/20001
4 years, 5 months ago (2016-07-19 22:59:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 23:06:41 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 23:08:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28dc7dba3702d164a97d03b6cf3c5411dbfcaa1e
Cr-Commit-Position: refs/heads/master@{#406407}

Powered by Google App Engine
This is Rietveld 408576698