services/ui/ws/server_window_surface.cc - Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/ws/server_window_surface.cc

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/ui/ws/server_window_surface.cc

diff --git a/services/ui/ws/server_window_surface.cc b/services/ui/ws/server_window_surface.cc

index 6f8f5254ce5a0a0b96e56ecda151df4a40eae1eb..fd7be5e71d2a2b1767c143c0a0023ee48318d212 100644

--- a/services/ui/ws/server_window_surface.cc

+++ b/services/ui/ws/server_window_surface.cc

@@ -27,7 +27,7 @@ ServerWindowSurface::ServerWindowSurface(

client_(std::move(client)),

binding_(this, std::move(request)) {

cc::SurfaceManager* surface_manager = manager_->GetSurfaceManager();

- surface_id_allocator_.RegisterSurfaceClientId(surface_manager);

+ surface_manager->RegisterSurfaceClientId(surface_id_allocator_.client_id());

surface_manager->RegisterSurfaceFactoryClient(

surface_id_allocator_.client_id(), this);

}

@@ -40,6 +40,7 @@ ServerWindowSurface::~ServerWindowSurface() {

cc::SurfaceManager* surface_manager = manager_->GetSurfaceManager();

surface_manager->UnregisterSurfaceFactoryClient(

surface_id_allocator_.client_id());

+ surface_manager->InvalidateSurfaceClientId(surface_id_allocator_.client_id());

}

void ServerWindowSurface::SubmitCompositorFrame(

« no previous file with comments | « services/ui/surfaces/display_compositor.cc ('k') | ui/compositor/compositor.h » ('j') | no next file with comments »