services/ui/surfaces/display_compositor.cc - Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/surfaces/display_compositor.cc

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/ui/surfaces/display_compositor.cc

diff --git a/services/ui/surfaces/display_compositor.cc b/services/ui/surfaces/display_compositor.cc

index b1a3024aac7dcec485a288812efdb8ed9246a94a..c6679dfec2f20cf7ff02126147f03069a46bfe03 100644

--- a/services/ui/surfaces/display_compositor.cc

+++ b/services/ui/surfaces/display_compositor.cc

@@ -31,7 +31,7 @@ DisplayCompositor::DisplayCompositor(

surfaces_state_(surfaces_state),

factory_(surfaces_state->manager(), this),

allocator_(surfaces_state->next_client_id()) {

- allocator_.RegisterSurfaceClientId(surfaces_state_->manager());

+ surfaces_state_->manager()->RegisterSurfaceClientId(allocator_.client_id());

surfaces_state_->manager()->RegisterSurfaceFactoryClient(

allocator_.client_id(), this);

@@ -78,6 +78,7 @@ DisplayCompositor::DisplayCompositor(

DisplayCompositor::~DisplayCompositor() {

surfaces_state_->manager()->UnregisterSurfaceFactoryClient(

allocator_.client_id());

+ surfaces_state_->manager()->InvalidateSurfaceClientId(allocator_.client_id());

}

void DisplayCompositor::SubmitCompositorFrame(

« no previous file with comments | « content/test/test_render_view_host.cc ('k') | services/ui/ws/server_window_surface.cc » ('j') | no next file with comments »