ui/compositor/compositor.h - Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/compositor/compositor.h

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/compositor/compositor.h

diff --git a/ui/compositor/compositor.h b/ui/compositor/compositor.h

index ee39c5943659e8f49eebe333bde230ea1ff3f9ac..05c3bcc93eca5df31894d4ea2df99eb154cc043a 100644

--- a/ui/compositor/compositor.h

+++ b/ui/compositor/compositor.h

@@ -128,9 +128,8 @@ class COMPOSITOR_EXPORT ContextFactory {

// Gets the task graph runner.

virtual cc::TaskGraphRunner* GetTaskGraphRunner() = 0;

- // Creates a Surface ID allocator with a new namespace.

- virtual std::unique_ptr<cc::SurfaceIdAllocator>

- CreateSurfaceIdAllocator() = 0;

+ // Allocate a new client ID for the display compositor.

+ virtual uint32_t AllocateSurfaceClientId() = 0;

// Gets the surface manager.

virtual cc::SurfaceManager* GetSurfaceManager() = 0;

« no previous file with comments | « services/ui/ws/server_window_surface.cc ('k') | ui/compositor/compositor.cc » ('j') | no next file with comments »