content/browser/compositor/surface_utils.h - Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/surface_utils.h

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed TestDelegatingOutputSurface Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/test/test_delegating_output_surface.cc ('K') | « content/browser/compositor/gpu_process_transport_factory.cc ('k') | content/browser/compositor/surface_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/surface_utils.h

diff --git a/content/browser/compositor/surface_utils.h b/content/browser/compositor/surface_utils.h

index 92bfe5786d5574a4caead4c2ac88d23f2523f6bb..3488e732cc14680a0c5080d13aec00192be81aa9 100644

--- a/content/browser/compositor/surface_utils.h

+++ b/content/browser/compositor/surface_utils.h

@@ -14,17 +14,14 @@

namespace cc {

class CopyOutputResult;

-class SurfaceIdAllocator;

class SurfaceManager;

} // namespace cc

namespace content {

-CONTENT_EXPORT

-std::unique_ptr<cc::SurfaceIdAllocator> CreateSurfaceIdAllocator();

+CONTENT_EXPORT uint32_t AllocateSurfaceClientId();

-CONTENT_EXPORT

-cc::SurfaceManager* GetSurfaceManager();

+CONTENT_EXPORT cc::SurfaceManager* GetSurfaceManager();

void CopyFromCompositingSurfaceHasResult(

const gfx::Size& dst_size_in_pixel,