ui::ContextFactory should not create SurfaceIdAllocators

cc/test/test_delegating_output_surface.cc

Index: cc/test/test_delegating_output_surface.cc
diff --git a/cc/test/test_delegating_output_surface.cc b/cc/test/test_delegating_output_surface.cc
index 15fca6c14cf857cfc899f5435236b786cec5a60b..2472120e670d00aa72afaa203d5176cff7632912 100644
--- a/cc/test/test_delegating_output_surface.cc
+++ b/cc/test/test_delegating_output_surface.cc
@@ -56,10 +56,15 @@ TestDelegatingOutputSurface::TestDelegatingOutputSurface(
   capabilities_.delegated_sync_points_required =
       !context_shared_with_compositor;
 
-  surface_id_allocator_->RegisterSurfaceClientId(surface_manager_.get());
+  surface_manager_->RegisterSurfaceClientId(surface_id_allocator_->client_id());
 }
 
-TestDelegatingOutputSurface::~TestDelegatingOutputSurface() {}
+TestDelegatingOutputSurface::~TestDelegatingOutputSurface() {
+  if (surface_manager_) {
+    surface_manager_->InvalidateSurfaceClientId(

[danakj, 2016/07/22 03:02:19]

Why is this here and not in DetachOutputSurface where
UnregisterSurfaceFactoryClient is? Is that intended? Are you aware this
currently runs on the main thread not the impl thread?

[Fady Samuel, 2016/07/22 12:23:38]

It should absolutely be next to UnregisterSurfaceFactoryClient given I want to
merge the two! Doh! Fixed. Thanks for catching this!

+        surface_id_allocator_->client_id());
+  }
+}
 
 bool TestDelegatingOutputSurface::BindToClient(OutputSurfaceClient* client) {
   if (!OutputSurface::BindToClient(client))