content/browser/compositor/gpu_process_transport_factory.cc - Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_process_transport_factory.cc

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed TestDelegatingOutputSurface Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/test/test_delegating_output_surface.cc ('K') | « content/browser/compositor/gpu_process_transport_factory.h ('k') | content/browser/compositor/surface_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/gpu_process_transport_factory.cc

diff --git a/content/browser/compositor/gpu_process_transport_factory.cc b/content/browser/compositor/gpu_process_transport_factory.cc

index 821f642ac2a9ee5cfa4d12fa336c1345a82859fe..dab470e9c5b72a88d69ba1be4b47f5514140cffe 100644

--- a/content/browser/compositor/gpu_process_transport_factory.cc

+++ b/content/browser/compositor/gpu_process_transport_factory.cc

@@ -687,13 +687,8 @@ ui::ContextFactory* GpuProcessTransportFactory::GetContextFactory() {

return this;

}

-std::unique_ptr<cc::SurfaceIdAllocator>

-GpuProcessTransportFactory::CreateSurfaceIdAllocator() {

- std::unique_ptr<cc::SurfaceIdAllocator> allocator =

- base::WrapUnique(new cc::SurfaceIdAllocator(next_surface_client_id_++));

- if (GetSurfaceManager())

- allocator->RegisterSurfaceClientId(GetSurfaceManager());

- return allocator;

+uint32_t GpuProcessTransportFactory::AllocateSurfaceClientId() {

+ return next_surface_client_id_++;

}

void GpuProcessTransportFactory::ResizeDisplay(ui::Compositor* compositor,