Split xfa_document_serialize into class files

Split xfa_document_serialize into class files

This CL moves CXFA_DataImporter and CXFA_DataExporter into their own files
and moves code to an anonymous namespace as necessary.

Committed: https://pdfium.googlesource.com/pdfium/+/3a7cc7382305e2d1f2793d9fea923f2428a87e64

[dsinclair, 2016-07-20 17:39:10]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-20 17:39:10]

PTAL.

[Wei Li, 2016-07-20 22:36:48]

lgtm

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataex...
File xfa/fxfa/parser/cxfa_dataexporter.cpp (right):

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataex...
xfa/fxfa/parser/cxfa_dataexporter.cpp:514: } break;
move this break inside also?

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataim...
File xfa/fxfa/parser/cxfa_dataimporter.cpp (right):

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataim...
xfa/fxfa/parser/cxfa_dataimporter.cpp:16: #include
"xfa/fxfa/parser/xfa_object.h"
still need fde_xml_imp.h?

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataim...
xfa/fxfa/parser/cxfa_dataimporter.cpp:26: if (!pDataDocumentParser)
Do we need to check this?

[Lei Zhang, 2016-07-20 22:56:31]

lgtm

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataex...
File xfa/fxfa/parser/cxfa_dataexporter.cpp (right):

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataex...
xfa/fxfa/parser/cxfa_dataexporter.cpp:321: FX_BOOL bSaveXML = FALSE) {
Probably not that hard to get rid of the default argument.

[dsinclair, 2016-07-21 13:34:37]

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataex...
File xfa/fxfa/parser/cxfa_dataexporter.cpp (right):

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataex...
xfa/fxfa/parser/cxfa_dataexporter.cpp:321: FX_BOOL bSaveXML = FALSE) {
On 2016/07/20 22:56:31, Lei Zhang wrote:
> Probably not that hard to get rid of the default argument.

Done.

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataex...
xfa/fxfa/parser/cxfa_dataexporter.cpp:514: } break;
On 2016/07/20 22:36:47, Wei Li wrote:
> move this break inside also?

Done.

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataim...
File xfa/fxfa/parser/cxfa_dataimporter.cpp (right):

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataim...
xfa/fxfa/parser/cxfa_dataimporter.cpp:16: #include
"xfa/fxfa/parser/xfa_object.h"
On 2016/07/20 22:36:47, Wei Li wrote:
> still need fde_xml_imp.h?

Done.

https://codereview.chromium.org/2164663004/diff/1/xfa/fxfa/parser/cxfa_dataim...
xfa/fxfa/parser/cxfa_dataimporter.cpp:26: if (!pDataDocumentParser)
On 2016/07/20 22:36:47, Wei Li wrote:
> Do we need to check this?

Done.

[dsinclair, 2016-07-21 19:04:07]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-21 19:04:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, weili@chromium.org
Link to the patchset: https://codereview.chromium.org/2164663004/#ps40001
(title: "Review fixes")

[commit-bot: I haz the power, 2016-07-21 19:04:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:04:36]

Description was changed from

==========
Split xfa_document_serialize into class files

This CL moves CXFA_DataImporter and CXFA_DataExporter into their own files
and moves code to an anonymous namespace as necessary.
==========

to

==========
Split xfa_document_serialize into class files

This CL moves CXFA_DataImporter and CXFA_DataExporter into their own files
and moves code to an anonymous namespace as necessary.

Committed:
https://pdfium.googlesource.com/pdfium/+/3a7cc7382305e2d1f2793d9fea923f2428a8...
==========

[commit-bot: I haz the power, 2016-07-21 19:04:37]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/3a7cc7382305e2d1f2793d9fea923f2428a8...