Make sk_app::WindowContext directly create a SkSurface without an intermediate GrRenderTarget

Make sk_app::WindowContext directly create a SkSurface without an intermediate GrRenderTarget
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165703002

Committed: https://skia.googlesource.com/skia/+/c7b4b28496a94c3fce7f11a18ce04deffbf9cfcb

[bsalomon, 2016-07-19 15:35:52]

Description was changed from

==========
Make sk_app::WindowContext directly create a SkSurface without an intermediate
GrRenderTarget
==========

to

==========
Make sk_app::WindowContext directly create a SkSurface without an intermediate
GrRenderTarget
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165703002
==========

[bsalomon, 2016-07-19 16:04:19]

bsalomon@google.com changed reviewers:
+ brianosman@google.com, jvanverth@google.com, robertphillips@google.com

[Brian Osman, 2016-07-19 16:08:19]

https://codereview.chromium.org/2165703002/diff/1/tools/viewer/sk_app/WindowC...
File tools/viewer/sk_app/WindowContext.h (right):

https://codereview.chromium.org/2165703002/diff/1/tools/viewer/sk_app/WindowC...
tools/viewer/sk_app/WindowContext.h:54: sk_sp<SkSurface>
createRenderSurface(GrBackendRenderTargetDesc, int colorBits);
Pass the desc by const& in both places? (Why is it passed by value here, and by
pointer later?)

[bsalomon, 2016-07-19 16:19:18]

https://codereview.chromium.org/2165703002/diff/1/tools/viewer/sk_app/WindowC...
File tools/viewer/sk_app/WindowContext.h (right):

https://codereview.chromium.org/2165703002/diff/1/tools/viewer/sk_app/WindowC...
tools/viewer/sk_app/WindowContext.h:54: sk_sp<SkSurface>
createRenderSurface(GrBackendRenderTargetDesc, int colorBits);
On 2016/07/19 16:08:18, Brian Osman wrote:
> Pass the desc by const& in both places? (Why is it passed by value here, and
by
> pointer later?)

It's required for this function and optional for the other (there is no desc
when createSurface is called from createOffscreenSurface).

[Brian Osman, 2016-07-19 16:21:26]

lgtm

[bsalomon, 2016-07-19 16:25:04]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-07-19 16:25:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 16:46:31]

Description was changed from

==========
Make sk_app::WindowContext directly create a SkSurface without an intermediate
GrRenderTarget
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165703002
==========

to

==========
Make sk_app::WindowContext directly create a SkSurface without an intermediate
GrRenderTarget
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165703002

Committed:
https://skia.googlesource.com/skia/+/c7b4b28496a94c3fce7f11a18ce04deffbf9cfcb
==========

[commit-bot: I haz the power, 2016-07-19 16:46:32]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c7b4b28496a94c3fce7f11a18ce04deffbf9cfcb

[jvanverth1, 2016-07-19 20:19:50]

https://codereview.chromium.org/2165703002/diff/1/tools/viewer/sk_app/VulkanW...
File tools/viewer/sk_app/VulkanWindowContext.cpp (right):

https://codereview.chromium.org/2165703002/diff/1/tools/viewer/sk_app/VulkanW...
tools/viewer/sk_app/VulkanWindowContext.cpp:261: fRenderTargets = new
sk_sp<GrRenderTarget>[fImageCount];
A little late to the party, but it looks like fRenderTargets isn't used any
more.

[bsalomon, 2016-07-19 20:38:37]

https://codereview.chromium.org/2165703002/diff/1/tools/viewer/sk_app/VulkanW...
File tools/viewer/sk_app/VulkanWindowContext.cpp (right):

https://codereview.chromium.org/2165703002/diff/1/tools/viewer/sk_app/VulkanW...
tools/viewer/sk_app/VulkanWindowContext.cpp:261: fRenderTargets = new
sk_sp<GrRenderTarget>[fImageCount];
On 2016/07/19 20:19:50, jvanverth1 wrote:
> A little late to the party, but it looks like fRenderTargets isn't used any
> more.

Oh duh! Will fix.