[wasm] Remove special memory type for (internal) globals and use local type instead.

[wasm] Remove special memory type for (internal) globals and use local type instead.

R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org
BUG=

Committed: https://crrev.com/d9eb33582fab45f84ad06d5a5416927f9aea2233
Cr-Commit-Position: refs/heads/master@{#37945}

[titzer, 2016-07-21 09:38:12]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 09:38:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 10:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 10:23:06]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-07-21 12:06:47]

I like it! lgtm

https://codereview.chromium.org/2165633006/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2165633006/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:236: module->globals.push_back({0, 0, kAstStmt, 0,
false});
Could you add a comment which says what this line is good for?

[titzer, 2016-07-21 12:12:57]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 12:13:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-07-21 12:15:10]

https://codereview.chromium.org/2165633006/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2165633006/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:236: module->globals.push_back({0, 0, kAstStmt, 0,
false});
On 2016/07/21 12:06:46, ahaas wrote:
> Could you add a comment which says what this line is good for?

Done.

[titzer, 2016-07-21 12:25:56]

The CQ bit was unchecked by titzer@chromium.org

[titzer, 2016-07-21 12:25:58]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-07-21 12:25:58]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2165633006/#ps20001
(title: "[wasm] Remove special memory type for (internal) globals and use local
type instead.")

[commit-bot: I haz the power, 2016-07-21 12:26:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 12:34:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-21 12:35:19]

Description was changed from

==========
[wasm] Remove special memory type for (internal) globals and use local type
instead.

R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org
BUG=
==========

to

==========
[wasm] Remove special memory type for (internal) globals and use local type
instead.

R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org
BUG=

Committed: https://crrev.com/d9eb33582fab45f84ad06d5a5416927f9aea2233
Cr-Commit-Position: refs/heads/master@{#37945}
==========

[commit-bot: I haz the power, 2016-07-21 12:35:20]

Patchset 2 (id:??) landed as
https://crrev.com/d9eb33582fab45f84ad06d5a5416927f9aea2233
Cr-Commit-Position: refs/heads/master@{#37945}