test/cctest/wasm/test-run-wasm-module.cc - Issue 2165633006: [wasm] Remove special memory type for (internal) globals and use local type instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/wasm/test-run-wasm-module.cc

Issue 2165633006: [wasm] Remove special memory type for (internal) globals and use local type instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: [wasm] Remove special memory type for (internal) globals and use local type instead. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/wasm/test-run-wasm-module.cc

diff --git a/test/cctest/wasm/test-run-wasm-module.cc b/test/cctest/wasm/test-run-wasm-module.cc

index 41978a0238f3863612f05aed6f345b1713695774..24b54c33f5207682012aef8aa4467b8d3c1261e7 100644

--- a/test/cctest/wasm/test-run-wasm-module.cc

+++ b/test/cctest/wasm/test-run-wasm-module.cc

@@ -156,8 +156,8 @@ TEST(Run_WasmModule_Global) {

TestSignatures sigs;

WasmModuleBuilder* builder = new (&zone) WasmModuleBuilder(&zone);

- uint32_t global1 = builder->AddGlobal(MachineType::Int32(), 0);

- uint32_t global2 = builder->AddGlobal(MachineType::Int32(), 0);

+ uint32_t global1 = builder->AddGlobal(kAstI32, 0);

+ uint32_t global2 = builder->AddGlobal(kAstI32, 0);

uint16_t f1_index = builder->AddFunction();

WasmFunctionBuilder* f = builder->FunctionAt(f1_index);

f->SetSignature(sigs.i_v());

« no previous file with comments | « test/cctest/wasm/test-run-wasm-64.cc ('k') | test/cctest/wasm/test-run-wasm-relocation.cc » ('j') | no next file with comments »