Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: src/wasm/encoder.h

Issue 2165633006: [wasm] Remove special memory type for (internal) globals and use local type instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: [wasm] Remove special memory type for (internal) globals and use local type instead. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/ast-decoder.cc ('k') | src/wasm/encoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/encoder.h
diff --git a/src/wasm/encoder.h b/src/wasm/encoder.h
index ea4dbe0d424ed6637a96fa15a0437790396a2876..cbb23fbd0c28476f31116809daf8010ae815d936 100644
--- a/src/wasm/encoder.h
+++ b/src/wasm/encoder.h
@@ -170,7 +170,7 @@ class WasmModuleBuilder : public ZoneObject {
// Building methods.
uint32_t AddFunction();
- uint32_t AddGlobal(MachineType type, bool exported);
+ uint32_t AddGlobal(LocalType type, bool exported);
WasmFunctionBuilder* FunctionAt(size_t index);
void AddDataSegment(WasmDataSegmentEncoder* data);
uint32_t AddSignature(FunctionSig* sig);
@@ -195,7 +195,7 @@ class WasmModuleBuilder : public ZoneObject {
ZoneVector<WasmFunctionBuilder*> functions_;
ZoneVector<WasmDataSegmentEncoder*> data_segments_;
ZoneVector<uint32_t> indirect_functions_;
- ZoneVector<std::pair<MachineType, bool>> globals_;
+ ZoneVector<std::pair<LocalType, bool>> globals_;
SignatureMap signature_map_;
int start_function_index_;
};
« no previous file with comments | « src/wasm/ast-decoder.cc ('k') | src/wasm/encoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698