Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2165553002:
gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices (Closed)
|
Created:
4 years, 5 months ago by robert.bradford Modified:
4 years, 3 months ago CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices
Extend the GPU workaround exception list to enable CMAA on all Broadwell
and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a
performance benefit.
BUG=535198
TEST=Boot cyan and observe that workaround is no longer listed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/58b5a5253da3242e0ff3bc2e7b963e55efc5bbd4
Cr-Commit-Position: refs/heads/master@{#414435}
Patch Set 1 #Patch Set 2 : Rebase & bump version #Patch Set 3 : Rebase & bump version #Messages
Total messages: 32 (21 generated)
Description was changed from ========== gpu: Enable CMAA for all Broadwell and Braswell parts Extend the GPU workaround exception list to enable CMAA on all Broadwell and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a performance benefit. BUG=535198 TEST=Boot cyan and observe that workaround is no longer listed. ========== to ========== gpu: Enable CMAA for all Broadwell and Braswell parts Extend the GPU workaround exception list to enable CMAA on all Broadwell and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a performance benefit. BUG=535198 TEST=Boot cyan and observe that workaround is no longer listed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== gpu: Enable CMAA for all Broadwell and Braswell parts Extend the GPU workaround exception list to enable CMAA on all Broadwell and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a performance benefit. BUG=535198 TEST=Boot cyan and observe that workaround is no longer listed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices Extend the GPU workaround exception list to enable CMAA on all Broadwell and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a performance benefit. BUG=535198 TEST=Boot cyan and observe that workaround is no longer listed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices Extend the GPU workaround exception list to enable CMAA on all Broadwell and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a performance benefit. BUG=535198 TEST=Boot cyan and observe that workaround is no longer listed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices Extend the GPU workaround exception list to enable CMAA on all Broadwell and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a performance benefit. BUG=535198 TEST=Boot cyan and observe that workaround is no longer listed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
robert.bradford@intel.com changed reviewers: + kbr@chromium.org
Hi Ken, we ran tests on other BDW devices (aura_yuna) and BSW (cyan) and see the expected performance improvements. Shall we turn CMAA on for all BDW and BSW devices? I also ran conformance tests and there are no failures different to samus.
The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kbr@chromium.org changed reviewers: + marcheu@chromium.org
Sounds fine to me, but someone who actively works on Chrome OS like marcheu@ should sign off on this. I'll approve once he does.
marcheu@ WDYT?
On 2016/08/16 11:16:08, robert.bradford wrote: > marcheu@ WDYT? Now that the issue I highlighted in https://bugs.chromium.org/p/chromium/issues/detail?id=634945 is now fixed in the WebGL conformance tests upstream can we move ahead with this wider enabling?
On 2016/08/24 13:34:14, robert.bradford wrote: > On 2016/08/16 11:16:08, robert.bradford wrote: > > marcheu@ WDYT? > > Now that the issue I highlighted in > https://bugs.chromium.org/p/chromium/issues/detail?id=634945 is now fixed in the > WebGL conformance tests upstream can we move ahead with this wider enabling? Well, the list of pci ids sucks, but apparently we can't do better. LGTM.
LGTM based on Stephane's review.
The CQ bit was checked by robert.bradford@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices Extend the GPU workaround exception list to enable CMAA on all Broadwell and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a performance benefit. BUG=535198 TEST=Boot cyan and observe that workaround is no longer listed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices Extend the GPU workaround exception list to enable CMAA on all Broadwell and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a performance benefit. BUG=535198 TEST=Boot cyan and observe that workaround is no longer listed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices Extend the GPU workaround exception list to enable CMAA on all Broadwell and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a performance benefit. BUG=535198 TEST=Boot cyan and observe that workaround is no longer listed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices Extend the GPU workaround exception list to enable CMAA on all Broadwell and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a performance benefit. BUG=535198 TEST=Boot cyan and observe that workaround is no longer listed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/58b5a5253da3242e0ff3bc2e7b963e55efc5bbd4 Cr-Commit-Position: refs/heads/master@{#414435} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/58b5a5253da3242e0ff3bc2e7b963e55efc5bbd4 Cr-Commit-Position: refs/heads/master@{#414435}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.chromium.org/2290323004/ by robert.bradford@intel.com. The reason for reverting is: Revert as a bisect of https://crbug.com/642290 points at a commit this commit depends upon. This revert will be followed by a revert of https://codereview.chromium.org/2112513003 which can be merged to the M53 branch..
Message was sent while issue was closed.
Can't actually do reverts of the workarounds file as we need to bump the version number so i'll adapt this CL manually. |
