Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 2165523004: Force MimeHandlerView to always use BrowserPlugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing lazyboy@'s and lfg@'s comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index ccfb0b990d3b2ee748ae053495a6f266f796ef71..7d22e2c3f0f6516e2de24d190783b136ebbbf0c5 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -156,6 +156,7 @@ class CONTENT_EXPORT BrowserPluginGuest : public GuestHost,
// Returns the embedder's RenderWidgetHostView if it is available.
// Returns nullptr otherwise.
RenderWidgetHostView* GetOwnerRenderWidgetHostView();
+ RenderWidgetHostView* GetTopLevelRenderWidgetHostView();
bool focused() const { return focused_; }
bool visible() const { return guest_visible_; }
@@ -253,6 +254,11 @@ class CONTENT_EXPORT BrowserPluginGuest : public GuestHost,
void ResendEventToEmbedder(const blink::WebInputEvent& event);
+ // TODO(ekaramad): This is used in forcing MimeHandlerView use BrowserPlugin
+ // even when --use-cross-process-frames-for-guests is used. Remove this once
+ // MimeHandlerView uses OOPIF (https://crbug.com/563285).
+ bool IsMimeHandlerViewGuest() const;
+
protected:
// BrowserPluginGuest is a WebContentsObserver of |web_contents| and
@@ -446,6 +452,8 @@ class CONTENT_EXPORT BrowserPluginGuest : public GuestHost,
BrowserPluginGuestDelegate* const delegate_;
+ bool is_mime_handler_view_guest_;
+
// Weak pointer used to ask GeolocationPermissionContext about geolocation
// permission.
base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698