components/guest_view/browser/guest_view_manager.cc - Issue 2165523004: Force MimeHandlerView to always use BrowserPlugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_manager.cc

Issue 2165523004: Force MimeHandlerView to always use BrowserPlugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing lazyboy@'s and lfg@'s comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/guest_view/browser/guest_view_manager.cc

diff --git a/components/guest_view/browser/guest_view_manager.cc b/components/guest_view/browser/guest_view_manager.cc

index d98ef1ac37b83393644195e7fb69d9211c1d3718..86d245fda7048408e183869c0f2ff40d8a72ccab 100644

--- a/components/guest_view/browser/guest_view_manager.cc

+++ b/components/guest_view/browser/guest_view_manager.cc

@@ -237,6 +237,12 @@ WebContents* GuestViewManager::GetFullPageGuest(

return result;

}

+bool GuestViewManager::IsForMimeHandlerViewGuest(

+ content::WebContents* web_contents) {

+ GuestViewBase* guest = GuestViewBase::FromWebContents(web_contents);

+ return guest && guest->IsMimeHandlerViewGuest();

void GuestViewManager::AddGuest(int guest_instance_id,

WebContents* guest_web_contents) {

CHECK(!ContainsKey(guest_web_contents_by_instance_id_, guest_instance_id));