Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2165523004: Force MimeHandlerView to always use BrowserPlugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing lazyboy@'s and lfg@'s comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index 15fbdb9edea36181badc0efd6498b90daface0e8..32175e0b55c9615016953d2fd6c5139f89dedfdc 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -209,7 +209,12 @@ gfx::Vector2dF RenderWidgetHostViewChildFrame::GetLastScrollOffset() const {
}
gfx::NativeView RenderWidgetHostViewChildFrame::GetNativeView() const {
- NOTREACHED();
+ // TODO(ekarmaad): To accomodate MimeHandlerViewGuest while embedded inside
+ // OOPIF-webview, we need to return the native view to be used by
+ // RenderWidgetHostViewGuest. Remove this once https://crbug.com/563285 is
+ // fixed.
+ if (frame_connector_)
+ return frame_connector_->GetRootRenderWidgetHostView()->GetNativeView();
lfg 2016/07/28 18:29:31 I think this should be using GetParentRenderWidget
EhsanK 2016/07/29 20:23:17 Acknowledged.
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698