third_party/WebKit/Source/core/editing/EditingUtilities.h - Issue 2164813003: Fix visible position calculation in accessible setSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.h

Issue 2164813003: Fix visible position calculation in accessible setSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert ChromeVox workaround and update test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs ('K') | « third_party/WebKit/LayoutTests/accessibility/set-selection-link.html ('k') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingUtilities.h

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.h b/third_party/WebKit/Source/core/editing/EditingUtilities.h

index 558b274897baf02a12ca73ae04cbe3b9f0cf1ef3..180e541b5824f569a0873ce72562abbdd003ca75 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilities.h

+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.h

@@ -278,14 +278,14 @@ CORE_EXPORT VisiblePositionInFlatTree firstEditableVisiblePositionAfterPositionI

// specified position due by canonicalization.

CORE_EXPORT VisiblePosition lastEditableVisiblePositionBeforePositionInRoot(const Position&, ContainerNode&);

CORE_EXPORT VisiblePositionInFlatTree lastEditableVisiblePositionBeforePositionInRoot(const PositionInFlatTree&, ContainerNode&);

-VisiblePosition visiblePositionBeforeNode(Node&);

+CORE_EXPORT VisiblePosition visiblePositionBeforeNode(Node&);

VisiblePosition visiblePositionAfterNode(Node&);

bool lineBreakExistsAtVisiblePosition(const VisiblePosition&);

int comparePositions(const VisiblePosition&, const VisiblePosition&);

-int indexForVisiblePosition(const VisiblePosition&, ContainerNode*& scope);

+CORE_EXPORT int indexForVisiblePosition(const VisiblePosition&, ContainerNode*& scope);

EphemeralRange makeRange(const VisiblePosition&, const VisiblePosition&);

EphemeralRange normalizeRange(const EphemeralRange&);

EphemeralRangeInFlatTree normalizeRange(const EphemeralRangeInFlatTree&);