chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs - Issue 2164813003: Fix visible position calculation in accessible setSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

Issue 2164813003: Fix visible position calculation in accessible setSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert ChromeVox workaround and update test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js ('k') | third_party/WebKit/LayoutTests/accessibility/set-selection-link.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

index 931960551ef7b4d2afe8224f41a3e25a91da6a25..0fbcb7d2183701b1c8999e245e09dd22300b1023 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

@@ -412,12 +412,12 @@ TEST_F('CursorsTest', 'InlineElementOffset', function() {

var cur = new cursors.Cursor(ofSelectionNode, 0);

assertEquals('of selection', cur.selectionNode_.name);

assertEquals(RoleType.staticText, cur.selectionNode_.role);

- assertEquals(13, cur.selectionIndex_);

+ assertEquals(0, cur.selectionIndex_);

var curIntoO = new cursors.Cursor(ofSelectionNode, 1);

assertEquals('of selection', curIntoO.selectionNode_.name);

assertEquals(RoleType.staticText, curIntoO.selectionNode_.role);

- assertEquals(14, curIntoO.selectionIndex_);

+ assertEquals(1, curIntoO.selectionIndex_);

var oRange = new cursors.Range(cur, curIntoO);

oRange.select();