Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: third_party/WebKit/Source/core/editing/EditingUtilities.h

Issue 2164813003: Fix visible position calculation in accessible setSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert ChromeVox workaround and update test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 // describes what this function returns, since it returns a position before 271 // describes what this function returns, since it returns a position before
272 // specified position due by canonicalization. 272 // specified position due by canonicalization.
273 CORE_EXPORT VisiblePosition firstEditableVisiblePositionAfterPositionInRoot(cons t Position&, ContainerNode&); 273 CORE_EXPORT VisiblePosition firstEditableVisiblePositionAfterPositionInRoot(cons t Position&, ContainerNode&);
274 CORE_EXPORT VisiblePositionInFlatTree firstEditableVisiblePositionAfterPositionI nRoot(const PositionInFlatTree&, ContainerNode&); 274 CORE_EXPORT VisiblePositionInFlatTree firstEditableVisiblePositionAfterPositionI nRoot(const PositionInFlatTree&, ContainerNode&);
275 // TODO(yosin) We should rename 275 // TODO(yosin) We should rename
276 // |lastEditableVisiblePositionBeforePositionInRoot()| to a better name which 276 // |lastEditableVisiblePositionBeforePositionInRoot()| to a better name which
277 // describes what this function returns, since it returns a position after 277 // describes what this function returns, since it returns a position after
278 // specified position due by canonicalization. 278 // specified position due by canonicalization.
279 CORE_EXPORT VisiblePosition lastEditableVisiblePositionBeforePositionInRoot(cons t Position&, ContainerNode&); 279 CORE_EXPORT VisiblePosition lastEditableVisiblePositionBeforePositionInRoot(cons t Position&, ContainerNode&);
280 CORE_EXPORT VisiblePositionInFlatTree lastEditableVisiblePositionBeforePositionI nRoot(const PositionInFlatTree&, ContainerNode&); 280 CORE_EXPORT VisiblePositionInFlatTree lastEditableVisiblePositionBeforePositionI nRoot(const PositionInFlatTree&, ContainerNode&);
281 VisiblePosition visiblePositionBeforeNode(Node&); 281 CORE_EXPORT VisiblePosition visiblePositionBeforeNode(Node&);
282 VisiblePosition visiblePositionAfterNode(Node&); 282 VisiblePosition visiblePositionAfterNode(Node&);
283 283
284 bool lineBreakExistsAtVisiblePosition(const VisiblePosition&); 284 bool lineBreakExistsAtVisiblePosition(const VisiblePosition&);
285 285
286 int comparePositions(const VisiblePosition&, const VisiblePosition&); 286 int comparePositions(const VisiblePosition&, const VisiblePosition&);
287 287
288 int indexForVisiblePosition(const VisiblePosition&, ContainerNode*& scope); 288 CORE_EXPORT int indexForVisiblePosition(const VisiblePosition&, ContainerNode*& scope);
289 EphemeralRange makeRange(const VisiblePosition&, const VisiblePosition&); 289 EphemeralRange makeRange(const VisiblePosition&, const VisiblePosition&);
290 EphemeralRange normalizeRange(const EphemeralRange&); 290 EphemeralRange normalizeRange(const EphemeralRange&);
291 EphemeralRangeInFlatTree normalizeRange(const EphemeralRangeInFlatTree&); 291 EphemeralRangeInFlatTree normalizeRange(const EphemeralRangeInFlatTree&);
292 CORE_EXPORT VisiblePosition visiblePositionForIndex(int index, ContainerNode* sc ope); 292 CORE_EXPORT VisiblePosition visiblePositionForIndex(int index, ContainerNode* sc ope);
293 293
294 // ------------------------------------------------------------------------- 294 // -------------------------------------------------------------------------
295 // HTMLElement 295 // HTMLElement
296 // ------------------------------------------------------------------------- 296 // -------------------------------------------------------------------------
297 297
298 // Functions returning HTMLElement 298 // Functions returning HTMLElement
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 // ------------------------------------------------------------------------- 360 // -------------------------------------------------------------------------
361 361
362 // Functions dispatch InputEvent 362 // Functions dispatch InputEvent
363 DispatchEventResult dispatchBeforeInputInsertText(EventTarget*, const String& da ta); 363 DispatchEventResult dispatchBeforeInputInsertText(EventTarget*, const String& da ta);
364 DispatchEventResult dispatchBeforeInputFromComposition(EventTarget*, InputEvent: :InputType, const String& data, InputEvent::EventCancelable); 364 DispatchEventResult dispatchBeforeInputFromComposition(EventTarget*, InputEvent: :InputType, const String& data, InputEvent::EventCancelable);
365 DispatchEventResult dispatchBeforeInputEditorCommand(EventTarget*, InputEvent::I nputType, const String& data, const RangeVector*); 365 DispatchEventResult dispatchBeforeInputEditorCommand(EventTarget*, InputEvent::I nputType, const String& data, const RangeVector*);
366 366
367 } // namespace blink 367 } // namespace blink
368 368
369 #endif 369 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698