Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 2164813002: Revert "Add a hack to set shouldPaint to true for force-composited iframes." (Closed)

Created:
4 years, 5 months ago by wkorman
Modified:
4 years, 5 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add a hack to set shouldPaint to true for force-composited iframes." Reason: Exploring as possible cause of compositing/paint time performance regression. Original change description: This works around a FCB chicken-egg problem in which we are unable to properly start painting floating iframes once they stop being composited. https://codereview.chromium.org/2009353003 BUG=610906, 619710 Committed: https://crrev.com/e080ea95241ea911fa5b97e27b18308ed4d8c1ae Cr-Commit-Position: refs/heads/master@{#406483}

Patch Set 1 #

Messages

Total messages: 15 (6 generated)
wkorman
4 years, 5 months ago (2016-07-19 20:49:08 UTC) #2
wkorman
Fixed duplicate text in change description. This is for master branch, following merge instructions which ...
4 years, 5 months ago (2016-07-19 20:50:14 UTC) #4
chrishtr
lgtm
4 years, 5 months ago (2016-07-19 21:58:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164813002/1
4 years, 5 months ago (2016-07-19 22:02:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/106791)
4 years, 5 months ago (2016-07-20 00:27:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164813002/1
4 years, 5 months ago (2016-07-20 01:06:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 04:25:16 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 04:25:27 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 04:26:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e080ea95241ea911fa5b97e27b18308ed4d8c1ae
Cr-Commit-Position: refs/heads/master@{#406483}

Powered by Google App Engine
This is Rietveld 408576698