Add a hack to set shouldPaint to true for force-composited iframes.

Add a hack to set shouldPaint to true for force-composited iframes.

This works around a FCB chicken-egg problem in which we are unable to properly
start painting floating iframes once they stop being composited.

BUG=610906
Committed: https://crrev.com/3e010d5a156f8420a7deaae243b9c9323517aef1
Cr-Commit-Position: refs/heads/master@{#396287}

[chrishtr, 2016-05-26 18:14:22]

Description was changed from

==========
none


none


none


none


none

BUG=
==========

to

==========
Add a hack to set shouldPaint to true for force-composited iframes.

This works around a FCB chicken-egg problem in which we are unable to properly
start painting floating iframes once they stop being composited.

BUG=610906
==========

[chrishtr, 2016-05-26 18:14:34]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-05-26 18:29:54]

lgtm with comments.

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/compositing/iframes/floating-self-painting-frame.html
(right):

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/compositing/iframes/floating-self-painting-frame.html:13:
onload = function() {
I think we should use runAfterLayoutAndPaint() because onload may not ensure a
compositing update.

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/FloatingObjects.cpp (right):

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/FloatingObjects.cpp:87: return
m_layoutObject->layer() &&
m_layoutObject->layer()->isSelfPaintingOnlyBecauseIsCompositedPart();
You can add a !RuntimeEnabledFeatures::slimmingPaintV2() condition here to
remind us to remove this for spv2.

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:3284: // behaves
properly). We always want to propagate the desire to paint the float as
Nit: Unnecessary change

https://codereview.chromium.org/2009353003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/FloatingObjects.cpp (right):

https://codereview.chromium.org/2009353003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/FloatingObjects.cpp:95:
newObj->setShouldPaint(!layoutObject->hasSelfPaintingLayer()  ||
newObj->shouldPaintForCompositedLayoutPart());
Nit: Remove extra space before '||'.

[chrishtr, 2016-05-26 18:49:30]

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/compositing/iframes/floating-self-painting-frame.html
(right):

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/compositing/iframes/floating-self-painting-frame.html:13:
onload = function() {
On 2016/05/26 at 18:29:54, Xianzhu wrote:
> I think we should use runAfterLayoutAndPaint() because onload may not ensure a
compositing update.

Done.

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/FloatingObjects.cpp (right):

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/FloatingObjects.cpp:87: return
m_layoutObject->layer() &&
m_layoutObject->layer()->isSelfPaintingOnlyBecauseIsCompositedPart();
On 2016/05/26 at 18:29:54, Xianzhu wrote:
> You can add a !RuntimeEnabledFeatures::slimmingPaintV2() condition here to
remind us to remove this for spv2.

Done

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/2009353003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:3284: // behaves
properly). We always want to propagate the desire to paint the float as
On 2016/05/26 at 18:29:54, Xianzhu wrote:
> Nit: Unnecessary change

Done.

https://codereview.chromium.org/2009353003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/FloatingObjects.cpp (right):

https://codereview.chromium.org/2009353003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/FloatingObjects.cpp:95:
newObj->setShouldPaint(!layoutObject->hasSelfPaintingLayer()  ||
newObj->shouldPaintForCompositedLayoutPart());
On 2016/05/26 at 18:29:54, Xianzhu wrote:
> Nit: Remove extra space before '||'.

Done.

[chrishtr, 2016-05-26 18:54:22]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-05-26 18:54:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2009353003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-26 18:54:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009353003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009353003/80001

[chrishtr, 2016-05-26 19:06:44]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-05-26 19:07:36]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-05-26 19:07:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2009353003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-05-26 19:08:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009353003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009353003/100001

[commit-bot: I haz the power, 2016-05-26 21:34:48]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-26 21:36:16]

Description was changed from

==========
Add a hack to set shouldPaint to true for force-composited iframes.

This works around a FCB chicken-egg problem in which we are unable to properly
start painting floating iframes once they stop being composited.

BUG=610906
==========

to

==========
Add a hack to set shouldPaint to true for force-composited iframes.

This works around a FCB chicken-egg problem in which we are unable to properly
start painting floating iframes once they stop being composited.

BUG=610906

Committed: https://crrev.com/3e010d5a156f8420a7deaae243b9c9323517aef1
Cr-Commit-Position: refs/heads/master@{#396287}
==========

[commit-bot: I haz the power, 2016-05-26 21:36:17]

Patchset 6 (id:??) landed as
https://crrev.com/3e010d5a156f8420a7deaae243b9c9323517aef1
Cr-Commit-Position: refs/heads/master@{#396287}